From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD05C43334 for ; Sun, 3 Jul 2022 23:50:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232766AbiGCXum (ORCPT ); Sun, 3 Jul 2022 19:50:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230174AbiGCXuk (ORCPT ); Sun, 3 Jul 2022 19:50:40 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A2345F79 for ; Sun, 3 Jul 2022 16:50:39 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id b26so11117974wrc.2 for ; Sun, 03 Jul 2022 16:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oRq/e/4c333beIFv9gNYaIdxDIpAmsD9/ZlSeuiZFzY=; b=xZ2sS7h3kN01lP5WAc6i9d0ekvpe8SzRjHWfh7G4ZP+QuV4A+Q8UM8gOCvwip8ugvm 1e/zqx1uABp5ft9chPXoGat+L0w7axrrlDwHmhVs0wZ4RrP2LoPIbBXIy+4si2Y2LRvK PztxPVetl2AUI8OunpRgQPZxQFJn/6f1XNQz920RvSuDfW5WoPyC3OOHslT5cxvssIPp 91bNVem4Z0gYZTFJmgFmRlTmqvFAXyWfWyeCFVONyOWwXlOKHq+dgyL1m09So+vlwtNr J+rEwjzC4ycC7FkPV5N7HYTDtCv5haXexhVsa4xDbtIiaUcyzJhh+3874zqPDSM+gcV1 t+gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oRq/e/4c333beIFv9gNYaIdxDIpAmsD9/ZlSeuiZFzY=; b=Pg3taU7Phn0GNIlBJ2ik6Ub1RnzwyKl46lxW+W+A6vNCrZQY8N+d/00CLIyxNopQZq BfFksIy2XFRTYZjMKWfbF+VhCnyLv7iRdPmMyfwY6+vodm4KVAXTwX7sTSFFDo5GxXNk csUhAx961KzlHGQwCo3GnbFOcXb9eU/I4Cqz7jKbKxk6paiZwSWg6skhNuJppY25JdAM TPdQsV4lJaZ9Ue8UKRrkZtQSANcfND/sw3PfzA+ZFuAizgiEjNi/Ea9INDJksMBhn7x1 VyManWLKaf/PpQcdC01aPQhV7dur5DGWfYpyF7EDPDfFOuEFQBeCF5efW8R6dVLnhiT3 C7vw== X-Gm-Message-State: AJIora8DgtpmtND5uJMv4H5dxIprNOAdiv6o2r5eub9+Wy4P47OLE13k /OdPSkSTBMMOyle+FDHlj1Lh1OCJJxHn++ipCk9jbZgU7Id5pg== X-Google-Smtp-Source: AGRyM1t6qMqQOkgpSTAQjUaSv3J6ZyxsLzoJ/MEWwCcPmDPYKAG11Z6w8LtxzlSFzumNlum/bsK2f37ENWE0pAIAsjw= X-Received: by 2002:a5d:5a15:0:b0:21d:630c:a609 with SMTP id bq21-20020a5d5a15000000b0021d630ca609mr7314612wrb.468.1656892237654; Sun, 03 Jul 2022 16:50:37 -0700 (PDT) MIME-Version: 1.0 References: <20220613195658.5607-1-brad@pensando.io> <20220613195658.5607-8-brad@pensando.io> In-Reply-To: From: Brad Larson Date: Sun, 3 Jul 2022 16:50:26 -0700 Message-ID: Subject: Re: [PATCH v5 07/15] dt-bindings: reset: amd,pensando-elbasr-reset: Add AMD Pensando SR Reset Controller bindings To: Krzysztof Kozlowski Cc: Linux ARM , Linux Kernel Mailing List , linux-mmc , Adrian Hunter , Al Cooper , Andy Shevchenko , Arnd Bergmann , blarson@amd.com, Catalin Marinas , Gabriel Somlo , gerg@linux-m68k.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Lee Jones , Mark Brown , Masahiro Yamada , Philipp Zabel , Pratyush Yadav , Randy Dunlap , Rob Herring , samuel@sholland.org, Serge Semin , suravee.suthikulpanit@amd.com, Tom Lendacky , Ulf Hansson , Will Deacon , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Mon, Jun 20, 2022 at 6:00 AM Krzysztof Kozlowski wrote: > > On 13/06/2022 21:56, Brad Larson wrote: > > From: Brad Larson > > > > Document bindings for AMD Pensando Elba SR Reset Controller > > > > Signed-off-by: Brad Larson > > --- > > .../reset/amd,pensando-elbasr-reset.yaml | 62 +++++++++++++++++++ > > 1 file changed, 62 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > > > diff --git a/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > new file mode 100644 > > index 000000000000..03bb86ebcfd3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > @@ -0,0 +1,62 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/reset/amd,pensando-elbasr-reset.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: AMD Pensando Elba SoC Reset Controller Device Tree Bindings > > Here and in all other patches: > s/Device Tree Bindings// Removed, must be implicit now, currently 366 files use it $ find . -name \*.yaml|xargs grep title|grep 'Device Tree Bindings'|wc 366 > > + > > +maintainers: > > + - Brad Larson > > + > > +description: | > > + AMD Pensando Elba SoC reset controller driver which supports a resource > > + controller connected to the Elba SoC over a SPI bus. The Elba reset > > + controller must be defined as a child node of the Elba SPI bus > > + chip-select 0 node. > > + > > + See also: > > + - dt-bindings/reset/amd,pensando-elba-reset.h > > + > > +properties: > > + $nodename: > > + pattern: "^reset-controller@[0-9a-f]+$" > > Skip the pattern. No particular need for it and unit address part is not > correct (const: 0). Deleted these lines $nodename: pattern: "^reset-controller@[0-9a-f]+$" > > > + > > + compatible: > > + const: amd,pensando-elbasr-reset > > + > > + reg: > > + const: 0 > > + > > + '#reset-cells': > > + const: 1 > > + > > +required: > > + - compatible > > + - reg > > + - '#reset-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > Missing file: > ls: cannot access 'include/dt-bindings/reset/amd,pensando-elba-reset.h': > No such file or directory > > > Send complete bindings, not parts of it. Did you test it? I am pretty > sure that this did not happen. :( Its in patch v5-0015 with the driver. I'll check this, the correct approach should be put all binding changes as individual patches up front or there are exceptions for new driver. $ cat v5-0015-reset-elbasr-Add-AMD-Pensando-Elba-SR-Reset-Contr.patch | grep diff diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile diff --git a/drivers/reset/reset-elbasr.c b/drivers/reset/reset-elbasr.c diff --git a/include/dt-bindings/reset/amd,pensando-elba-reset.h b/include/dt-bindings/reset/amd,pensando-elba-reset.h Yes, tested it with the following and no warnings or errors make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/amd,pensando.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/syscon.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/amd,pensando.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/syscon.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > + spi0 { > > spi Changed to spi Regards, Brad