From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E3BBC43216 for ; Mon, 23 Aug 2021 01:07:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A88361354 for ; Mon, 23 Aug 2021 01:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234548AbhHWBHq (ORCPT ); Sun, 22 Aug 2021 21:07:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231807AbhHWBHo (ORCPT ); Sun, 22 Aug 2021 21:07:44 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14F34C061757 for ; Sun, 22 Aug 2021 18:07:03 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id s3so11379857edd.11 for ; Sun, 22 Aug 2021 18:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pjckf6bfV/IeJNN9n6MQVl/LTL3lu1yq7lS4IYzu/QM=; b=YXvUInxkTo+QS04+RTXnvdY5Tut9xBKcT9moQ79TGp2GjLkU/lF29770JsA6UY+UOn yjlARSI3QSab1F39xGyUm9LqcHKPE++VUejnLyKwbHAVdhKJnDNssxuQqlmSJhbAj2OT YxqGNv5II7hqHyRemXMsdL1BA/qgC6MEvPlCNcoHEhp6bZw3rOvoOzKVrjATtwfU9zue R0esUcu67bVhSd0ErcQC/7zaqVKqAAK4SPfsJQ+wsgTJKwMXBkS1CDhRG2++ClbJLMg2 f77F2jBXBEzMMA7p3ZzlFd9ahFPEAgnqx1ZNVe670GdAp6aOQ7bP8biCveNS+9nuRpn+ Dhfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pjckf6bfV/IeJNN9n6MQVl/LTL3lu1yq7lS4IYzu/QM=; b=bIhdURxJk2aqk3NuiaEfl0/X/rVQ3E6zp6ghLdpcexzaWTpuYI8jXYp56D7bogh4Kd Uwy859OJrf5/26RKFjPeuYm79JLrMtfsbggyVX6O0dDf1JKorOnq7G9YfgpOA/EUfIPi xdaZNqLxi6btHaoUEJrZxVjenqO4LI8xCNOs0uKVGEN4r7sqeQmI/cl8lZxamJKD58HU 9XFQM1KPo/tPF9gzlScxt8PZvUHd4RerxH1V+q+mUnv/oLpos7e4Ad2cF0RUqvR/Yf6d 4ITvPXP4tv5ycH2nBL8sb4IAtqmUYDDrfmMRfO7Iix84HAL3G2f1QGkDEoqNUfGobXHn tUbQ== X-Gm-Message-State: AOAM531QvWdry7zRd8V+lT8Ic2x0hBoC0Q6x/YNKPVow2PFRAr6603gv A67E4T4dmiXTBIGvkKS4ebNZfB68xeyPPf4nj9DzTteb8R4GJg== X-Google-Smtp-Source: ABdhPJxLjyDYm7QVxm1dvdfIEw9t3Et/mk1X0dx98a7+Jgg205IWLNBlgQOSRuBoYLny9Mb7LfeCW8J2s/qhMUfMTOY= X-Received: by 2002:a05:6402:5208:: with SMTP id s8mr35097217edd.222.1629680821623; Sun, 22 Aug 2021 18:07:01 -0700 (PDT) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-2-brad@pensando.io> In-Reply-To: From: Brad Larson Date: Sun, 22 Aug 2021 18:06:51 -0700 Message-ID: Subject: Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control To: "Elliott, Robert (Servers)" Cc: "linux-arm-kernel@lists.infradead.org" , "arnd@arndb.de" , "linus.walleij@linaro.org" , "bgolaszewski@baylibre.com" , "broonie@kernel.org" , "fancer.lancer@gmail.com" , "adrian.hunter@intel.com" , "ulf.hansson@linaro.org" , "olof@lixom.net" , "linux-gpio@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Elliott, On Thu, Mar 4, 2021 at 12:44 PM Elliott, Robert (Servers) wrote: [...] > > +config GPIO_ELBA_SPICS > > + bool "Pensando Elba SPI chip-select" > > + depends on ARCH_PENSANDO_ELBA_SOC > > + help > > + Say yes here to support the Pensndo Elba SoC SPI chip-select > > driver > > Pensndo should be Pensando Fixed the typo, thanks. > > diff --git a/drivers/gpio/gpio-elba-spics.c b/drivers/gpio/gpio-elba-spics.c > > + * Pensando Elba ASIC SPI chip select driver > ... > > +MODULE_LICENSE("GPL v2"); > > +MODULE_DESCRIPTION("Elba SPI chip-select driver"); > > I think it's conventional to include the company name there, so > start that with "Pensando Elba" Ok, thanks. BTW I deleted these lines as I should have used builtin_platform_driver() and not a loadable module. > Also, "SoC" and "ASIC" are sometimes included after Elba, but sometimes > are not. Consistency might be helpful. > > > +static const struct of_device_id ebla_spics_of_match[] = { > ... > > + .of_match_table = ebla_spics_of_match, > > ebla should be elba Fixed the typo and using SoC which is more accurate. Regards, Brad