From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9770C433F5 for ; Thu, 26 May 2022 00:21:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344734AbiEZATy (ORCPT ); Wed, 25 May 2022 20:19:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344338AbiEZATu (ORCPT ); Wed, 25 May 2022 20:19:50 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57F1266AD5 for ; Wed, 25 May 2022 17:19:47 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 67-20020a1c1946000000b00397382b44f4so214301wmz.2 for ; Wed, 25 May 2022 17:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rvyRm5Q/r/S5AC3OCiGwFo1KyIi4GmHKo/WvAYlzwmY=; b=h/FkCqpobe35YJc146CKhRO71JljnxwQBGwvYvsR9DljgVXTXTpKwLVSMwywDv+1tS Dmc8XCASYU8zmDisPay1AFEHLY3+Z43QB46x1QJO+TJ0mpDDLSfutSKEBeoMSOGdPlzs 5M6rpvi548zAECvIetFq8EGO/OutGXBhFJiEqkedkBQypY5HQUENyYB1vkxfqjcJ9gxO Ej9Q0TmI8VT+gXtLkNZ5rxcoq4xqlUDFPbyx2fPGoi+wCkGcbM50nGLE0tiymF+0sDBE QZplrGXTII8qid0zqJiJN/4fjt1WKzFAouk6dfki3ttE0jdPWSDpTTxktrvueHJBKNAx HSwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rvyRm5Q/r/S5AC3OCiGwFo1KyIi4GmHKo/WvAYlzwmY=; b=Dos2bbh4DgmZ4wHuSs7z3HClhui68CwWKSGuQo3WowWa+k/q6CGNDYAb5Qgtt2Xyhh 6IjbEfjmNXjD3t2/P+9/wjFPjj+xSkeGCFS1KYVHhA5yAKM2v2Nki1EcZu6abR0Ghndk 8vBx7rehKEIkt5Dt81aHZOc780WA/HFQ6/JNtM+1cRNGVHFCuFD3GJgFv6RhcfPkb03R 3xRi83D3m35lJT0FIUbkFof6J/d74zMxjOymUchD+3XdmfCI0izK59zYyvXQV2H/6y5l mwd6S/u9X6KN1nBYU3ILI3rxutKr18g7tcRerds4nAYE5w8eYElCAlBa1YCog+YV/bY3 Cdnw== X-Gm-Message-State: AOAM530AeVz6XBykZ4vRwVIZSi4VimcCh3Z5/OXDL5EzA7K5B3bkaRGE gWV1wer07gBP7kOMklCrLsXv6eYQHUh1xPSEgwmDLQ== X-Google-Smtp-Source: ABdhPJy/dRDyn+Keu4U0c9gK7VXdr+BW11BU+IY+GQAiAKGDy36VrSwz2Mg+0dYg+MNRP78khenZHfMasXMazGY+SKQ= X-Received: by 2002:a05:600c:3515:b0:394:8c7e:fbde with SMTP id h21-20020a05600c351500b003948c7efbdemr10219880wmq.165.1653524385886; Wed, 25 May 2022 17:19:45 -0700 (PDT) MIME-Version: 1.0 References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-12-brad@pensando.io> In-Reply-To: From: Brad Larson Date: Wed, 25 May 2022 17:19:34 -0700 Message-ID: Subject: Re: [PATCH 11/11] arm64: dts: Add Pensando Elba SoC support To: Krzysztof Kozlowski Cc: Linux ARM , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , David Clear , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Thu, Apr 7, 2022 at 12:06 PM Krzysztof Kozlowski wrote: > > On 07/04/2022 01:36, Brad Larson wrote: > > Add Pensando common and Elba SoC specific device nodes > > > > +&spi0 { > > + num-cs = <4>; > > + cs-gpios = <0>, <0>, <&porta 1 GPIO_ACTIVE_LOW>, > > + <&porta 7 GPIO_ACTIVE_LOW>; > > + status = "okay"; > > + spi0_cs0@0 { > > Generic node name needed matching the class of a devicxe. The device on this spi bus is a FPGA with 4 functions and looking at other projects I've changed it to a resource-controller node name. On cs0 there is a sub-device reset-controller added in the upcoming patchset to enable hardware reset of the eMMC device. > > + compatible = "semtech,sx1301"; /* Enable spidev */ > > This comment is a bit odd... did you just use random compatible from > spidev instead of defining proper compatible? Yes, because adding a compatible was nacked. We have a driver added (two actually, mfd and reset driver) for the next patch update. > > + #address-cells = <1>; > > + #size-cells = <1>; > > Why address/size cells? Removed where not needed > > + spi-max-frequency = <12000000>; > > + reg = <0>; > > Please put reg just after compatible. It's the most common pattern. Yes, moved reg to be right after compatible > > + }; > > + > > + spi0_cs1@1 { > > + compatible = "semtech,sx1301"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + spi-max-frequency = <12000000>; > > + reg = <1>; > > + }; > > + (...) > > + > > + mssoc: mssoc@307c0000 { > > Generic node name. Changed to syscon > > + compatible = "syscon", "simple-mfd"; > > This does not look correct. Syscon is okay, but why do you need > simple-mfd (there are no children here)? Yes, removed "simple-mfd" Regards, Brad