From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755920Ab3C1Gl1 (ORCPT ); Thu, 28 Mar 2013 02:41:27 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33558 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751472Ab3C1Gl0 (ORCPT ); Thu, 28 Mar 2013 02:41:26 -0400 MIME-Version: 1.0 In-Reply-To: <51537F02.7090500@samsung.com> References: <1364383410-15093-1-git-send-email-sachin.kamat@linaro.org> <51537F02.7090500@samsung.com> Date: Thu, 28 Mar 2013 12:11:25 +0530 Message-ID: Subject: Re: [PATCH 1/2] extcon: max77693: Fix return value From: Sachin Kamat To: Chanwoo Choi Cc: linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com, patches@linaro.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chanwoo, On 28 March 2013 04:51, Chanwoo Choi wrote: > On 03/27/2013 08:23 PM, Sachin Kamat wrote: >> Return the value obtained from the function instead of hardcoding. >> Silences the following warning: >> drivers/extcon/extcon-max77693.c:297 max77693_muic_set_path() >> info: why not propagate 'ret' from max77693_update_reg() instead of (-11)? >> drivers/extcon/extcon-max77693.c:310 max77693_muic_set_path() >> info: why not propagate 'ret' from max77693_update_reg() instead of (-11)? >> >> Signed-off-by: Sachin Kamat [snip] >> dev_info(info->dev, > As my comment about "extcon: max8997: Fix return value", > I wish to receive one patch which modify all of return value with 'ret' > in extcon-max77693.c. Resent both patches as per your suggestion. -- With warm regards, Sachin