From: Sachin Kamat <sachin.kamat@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH 1/1] tty: vt: Remove redundant null check before kfree.
Date: Thu, 22 Nov 2012 10:49:43 +0530 [thread overview]
Message-ID: <CAK9yfHxu1xgDmQJLN80f40cxMsamVreH_k6nngkOWv-x9_wzSA@mail.gmail.com> (raw)
In-Reply-To: <20121122003835.GA24936@kroah.com>
On 22 November 2012 06:08, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Nov 22, 2012 at 12:17:00AM +0100, Jiri Slaby wrote:
>> On 11/22/2012 12:00 AM, Greg KH wrote:
>> > On Wed, Nov 21, 2012 at 11:43:34PM +0100, Jiri Slaby wrote:
>> >> On 11/21/2012 03:46 PM, Greg KH wrote:
>> >>> On Wed, Nov 21, 2012 at 10:49:07AM +0530, Sachin Kamat wrote:
>> >>>> --- a/drivers/tty/vt/consolemap.c
>> >>>> +++ b/drivers/tty/vt/consolemap.c
>> >>>> @@ -410,10 +410,8 @@ static void con_release_unimap(struct uni_pagedir *p)
>> >>>> kfree(p->inverse_translations[i]);
>> >>>> p->inverse_translations[i] = NULL;
>> >>>> }
>> >>>> - if (p->inverse_trans_unicode) {
>> >>>> - kfree(p->inverse_trans_unicode);
>> >>>> - p->inverse_trans_unicode = NULL;
>> >>>> - }
>> >>>> + kfree(p->inverse_trans_unicode);
>> >>>> + p->inverse_trans_unicode = NULL;
>> >>>
>> >>> kfree with NULL is a no-op, but the line after that just caused a kernel
>> >>> crash if it was NULL, so I can't accept this type of thing.
>> >>
>> >> Greg, I'm not sure -- what do you mean here? The change actually looks
>> >> fine to me... We do not dereference p->inverse_trans_unicode there.
>> >
>> > If we never dereference it, why is it being set to NULL?
>>
>> I'm not disputing the assignment. Let it there. But I do not see any
>> issues with the patch. What problem do you see exactly?
>
> {sigh} Nothing. I don't know what I was thinking, my apologies
> Sachin, there's nothing wrong with this patch.
>
> I blame my fried brain, after reviewing all of those __dev* removal
> patches :)
>
> Sachin, can you resend these patches so I can apply them?
No problem Greg. I will send them again.
>
> thanks,
>
> greg k-h
--
With warm regards,
Sachin
prev parent reply other threads:[~2012-11-22 18:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 5:19 [PATCH 1/1] tty: vt: Remove redundant null check before kfree Sachin Kamat
2012-11-21 14:46 ` Greg KH
2012-11-21 14:51 ` Sachin Kamat
2012-11-21 15:16 ` Greg KH
2012-11-21 15:29 ` Sachin Kamat
2012-11-21 16:54 ` Greg KH
2012-11-21 22:43 ` Jiri Slaby
2012-11-21 23:00 ` Greg KH
2012-11-21 23:17 ` Jiri Slaby
2012-11-22 0:38 ` Greg KH
2012-11-22 5:19 ` Sachin Kamat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK9yfHxu1xgDmQJLN80f40cxMsamVreH_k6nngkOWv-x9_wzSA@mail.gmail.com \
--to=sachin.kamat@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).