linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sachin Kamat <sachin.kamat@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	stable@vger.kernel.org, Sangbeom Kim <sbkim73@samsung.com>
Subject: Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay
Date: Mon, 26 May 2014 13:37:22 +0530	[thread overview]
Message-ID: <CAK9yfHzOcmL30nH1c4iQFfosQ1oWerwQKxkQvX4KxCr4mj+G0Q@mail.gmail.com> (raw)
In-Reply-To: <1400854775.7331.6.camel@AMDC1943>

Hi Krzysztof

Apologies for the delay. I was on vacation during the early part of
this month and
got busy with some other stuff later and this mail fell through the cracks.


On 23 May 2014 19:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> Hi Sachin,
>
> The s2mpa01 regulator driver uses wrong registers for ramp delay (buck1
> and buck3 in RAMP1, buck6 in RAMP2) but I am not sure which layout is
> proper (it seems that that buck1 should be in RAMP2 register).
>
> Could you check in S2MPA01 datasheet the registers for ramp delay for
> buck1, buck3 and buck6?

I checked the datasheet available with me and according to it

buck 1 and 6 share the ramp register 0x11 (RAMP2) (bit 4 and 5) and buck 3 uses
bit 4 and 5 of register 0x10 (RAMP1).

-- 
With warm regards,
Sachin

  reply	other threads:[~2014-05-26  8:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07  9:52 [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay Krzysztof Kozlowski
2014-05-07 11:10 ` Krzysztof Kozlowski
2014-05-23 14:19   ` Krzysztof Kozlowski
2014-05-26  8:07     ` Sachin Kamat [this message]
2014-05-26  8:34       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK9yfHzOcmL30nH1c4iQFfosQ1oWerwQKxkQvX4KxCr4mj+G0Q@mail.gmail.com \
    --to=sachin.kamat@linaro.org \
    --cc=broonie@kernel.org \
    --cc=k.kozlowski@samsung.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sbkim73@samsung.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).