From: Ohad Ben-Cohen <ohad@wizery.com>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: Lina Iyer <lina.iyer@linaro.org>, "Anna, Suman" <s-anna@ti.com>,
Bjorn Andersson <Bjorn.Andersson@sonymobile.com>,
Andy Gross <agross@codeaurora.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH RFC] hwspinlock: Don't take software spinlock before hwspinlock
Date: Sat, 6 Jun 2015 06:28:48 +0300 [thread overview]
Message-ID: <CAK=WgbYSev_y45Gh3oJ+1xNPdvvRy=gpa=iSTgPydNodPeh3sQ@mail.gmail.com> (raw)
In-Reply-To: <557235C1.3020001@codeaurora.org>
On Sat, Jun 6, 2015 at 2:50 AM, Jeffrey Hugo <jhugo@codeaurora.org> wrote:
> If you still wish to scope out a capability based alternative, would you
> please provide some details about how you envision it working? An example
> of the API, how it would be used, future usecases that might be covered by
> it, etc. That would give us specifics we can discuss and weigh the merits
> of.
How about:
- add a 'hwcaps' member to hwspinlock_device, and define single cap
called HWL_CAP_ALLOW_RAW
- add new 'hwcaps' parameter to hwspin_lock_register
- omap_hwspinlock.c will pass NULL, qcom_hwspinlock will pass HWL_CAP_ALLOW_RAW
- hwspin_lock_register will set hwcaps accordingly
- before a lock is taken in RAW mode, the capabilities are checked
- document everything nicely
Unless I'm missing something, it should take 5 minutes or less. For
reference, feel free to check out mmc_host's caps member and its
usage.
Thanks,
Ohad.
prev parent reply other threads:[~2015-06-06 3:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 17:07 [PATCH RFC] hwspinlock: Don't take software spinlock before hwspinlock Lina Iyer
2015-05-09 9:25 ` Ohad Ben-Cohen
2015-05-11 14:46 ` Lina Iyer
2015-05-16 9:03 ` Ohad Ben-Cohen
2015-05-18 15:03 ` Lina Iyer
2015-05-19 20:13 ` Andy Gross
2015-05-20 22:02 ` Lina Iyer
2015-05-23 7:35 ` Ohad Ben-Cohen
2015-05-26 20:36 ` Lina Iyer
2015-06-05 1:09 ` Ohad Ben-Cohen
2015-06-05 23:50 ` Jeffrey Hugo
2015-06-06 3:28 ` Ohad Ben-Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK=WgbYSev_y45Gh3oJ+1xNPdvvRy=gpa=iSTgPydNodPeh3sQ@mail.gmail.com' \
--to=ohad@wizery.com \
--cc=Bjorn.Andersson@sonymobile.com \
--cc=agross@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).