From: Ohad Ben-Cohen <ohad@wizery.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
David Brown <davidb@codeaurora.org>,
Tony Lindgren <tony@atomide.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Stuart Yoder <b08248@gmail.com>,
Scott Wood <scottwood@freescale.com>,
Hiroshi Doyu <hdoyu@nvidia.com>
Subject: Re: [PATCH 2/6] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute
Date: Fri, 27 Jan 2012 13:00:02 +0200 [thread overview]
Message-ID: <CAK=WgbZQB+76FuJXK82x09CieDmF23zLQ8KbHbEtjnQsc_4axg@mail.gmail.com> (raw)
In-Reply-To: <20120127102608.GK19255@amd.com>
On Fri, Jan 27, 2012 at 12:26 PM, Joerg Roedel <joerg.roedel@amd.com> wrote:
> I fell also uncomfortable with the missing type-safety of this
> interface. But the alternative is to have dedicated functions for
> set/get each attribute. Well, it depends on how many attributes we have
> in the end, but given that the PAMU guys already have need for a number
> of hardware specific attributes it is likely that having individual
> functions makes the api too complex in the end.
>
> But probably we can replace the 'void *data' with a 'union
> domain_attr'? This will give us some type-safety.
>
I was thinking that since the geometry concept is actually handled by
the core itself, it could probably have its own dedicated function.
Not sure how many other functions like that we might end up having
eventually, but I personally prefer the dedicated API over a single
multiplexer which is prone to error and (somewhat) harder to
debug/read.
Real vendor-specific attributes do probably justifies an all-catch
attribute API, I agree. Though we should probably try to minimize
them, and where possible, implement them in the core too, for the
benefit of everyone.
Thanks,
Ohad.
next prev parent reply other threads:[~2012-01-27 11:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 18:40 [PATCH 0/6 v2] IOMMU: Make IOMMU-API ready for GART-like hardware Joerg Roedel
2012-01-26 18:40 ` [PATCH 1/6] iommu: Add domain-attribute handlers Joerg Roedel
2012-01-26 18:40 ` [PATCH 2/6] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute Joerg Roedel
2012-01-27 7:08 ` Ohad Ben-Cohen
2012-01-27 10:26 ` Joerg Roedel
2012-01-27 11:00 ` Ohad Ben-Cohen [this message]
2012-01-27 13:03 ` Joerg Roedel
2012-01-28 20:44 ` Ohad Ben-Cohen
2012-01-30 14:49 ` Joerg Roedel
2012-01-30 15:42 ` Ohad Ben-Cohen
2012-01-26 18:40 ` [PATCH 3/6] iommu/vt-d: " Joerg Roedel
2012-01-26 18:40 ` [PATCH 4/6] iommu/omap: " Joerg Roedel
2012-01-26 18:40 ` [PATCH 5/6] iommu/msm: " Joerg Roedel
2012-01-27 0:07 ` David Brown
2012-01-26 18:40 ` [PATCH 6/6] iommu/tegra: " Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK=WgbZQB+76FuJXK82x09CieDmF23zLQ8KbHbEtjnQsc_4axg@mail.gmail.com' \
--to=ohad@wizery.com \
--cc=b08248@gmail.com \
--cc=davidb@codeaurora.org \
--cc=dwmw2@infradead.org \
--cc=hdoyu@nvidia.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).