From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2993306AbbEPIn6 (ORCPT ); Sat, 16 May 2015 04:43:58 -0400 Received: from mail-ie0-f180.google.com ([209.85.223.180]:34358 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993219AbbEPIns (ORCPT ); Sat, 16 May 2015 04:43:48 -0400 MIME-Version: 1.0 X-Originating-IP: [85.250.79.171] In-Reply-To: <5550C43F.3070507@ti.com> References: <1427917039-43206-1-git-send-email-d-gerlach@ti.com> <1427917039-43206-5-git-send-email-d-gerlach@ti.com> <5550C43F.3070507@ti.com> From: Ohad Ben-Cohen Date: Sat, 16 May 2015 11:43:26 +0300 Message-ID: Subject: Re: [PATCH v3 4/4] remoteproc/wkup_m3: add a remoteproc driver for TI Wakeup M3 To: Suman Anna Cc: Dave Gerlach , linux-arm , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "devicetree@vger.kernel.org" , Kevin Hilman , Tony Lindgren Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Suman, On Mon, May 11, 2015 at 6:01 PM, Suman Anna wrote: > We don't have any carveouts or usage of any external DDR, as this > processor is used during Power Management, like cpuidle or suspend path, > and is used to control the MPU and DDR states. The resource table is > very simple and straight-forward [1]. Ok thanks. Could you please document in the patch how the WkupM3 memory is managed? Perhaps add to this latter explanation of yours also what stands behind the umem/dmem names, justify usage of '__force' and document the code around the l4_offset math (which I suspect may not always be correct, as it seems the value of l4_offset depends on the order of mem resources returned by platform_get_resource_byname). Thanks, Ohad.