From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753755AbbCLJE3 (ORCPT ); Thu, 12 Mar 2015 05:04:29 -0400 Received: from mail-ig0-f179.google.com ([209.85.213.179]:44424 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753717AbbCLJEY (ORCPT ); Thu, 12 Mar 2015 05:04:24 -0400 MIME-Version: 1.0 X-Originating-IP: [89.138.254.120] In-Reply-To: <1420838519-15669-2-git-send-email-s-anna@ti.com> References: <1420838519-15669-1-git-send-email-s-anna@ti.com> <1420838519-15669-2-git-send-email-s-anna@ti.com> From: Ohad Ben-Cohen Date: Thu, 12 Mar 2015 11:04:03 +0200 Message-ID: Subject: Re: [PATCH v3 1/2] remoteproc: use a flag to detect the presence of IOMMU To: Suman Anna Cc: Dave Gerlach , Robert Tivy , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , linux-arm , Linus Walleij Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 9, 2015 at 11:21 PM, Suman Anna wrote: > The remoteproc driver core currently relies on iommu_present() on > the bus the device is on, to perform MMU management. However, this > logic doesn't scale for multi-arch, especially for processors that > do not have an IOMMU. Replace this logic instead by using a h/w > capability flag for the presence of IOMMU in the rproc structure. > > This issue is seen on OMAP platforms when trying to add a remoteproc > driver for a small Cortex M3 called the WkupM3 used for suspend / > resume management on TI AM335/AM437x SoCs. This processor does not > have an MMU. Same is the case with another processor subsystem > PRU-ICSS on AM335/AM437x. All these are platform devices, and the > current iommu_present check will not scale for the same kernel image > to support OMAP4/OMAP5 and AM335/AM437x. > > The existing platform implementation drivers - OMAP remoteproc, STE > Modem remoteproc and DA8xx remoteproc, are updated as well to properly > configure the newly added rproc field. > > Cc: Robert Tivy > Cc: Linus Walleij > Signed-off-by: Suman Anna Applied to remoteproc's for-next branch. Thanks, Ohad.