linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chu Lin <linchuyuan@google.com>
To: Guenter Roeck <linux@roeck-us.net>,
	robh+dt@kernel.org, jdelvare@suse.com
Cc: Kais Belgaied <belgaied@google.com>,
	Jason Ling <jasonling@google.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zhongqi Li <zhongqil@google.com>
Subject: Re: [PATCH v3] dt-bindings: hwmon: adm1272: add analog,temp1-enable binding
Date: Tue, 4 May 2021 16:16:42 -0700	[thread overview]
Message-ID: <CAKCA56AziFJGnX6u5D35psboOUFZhSOGxpkb_4JaRo5mVk7fnQ@mail.gmail.com> (raw)
In-Reply-To: <20200721034815.2045545-1-linchuyuan@google.com>

Hi Rob,

Please review this device tree patch when you have a chance.

Thanks,
Chu

On Mon, Jul 20, 2020 at 8:48 PM Chu Lin <linchuyuan@google.com> wrote:
>
> Problem:
>         adm1272 and adm1278 supports temperature sampling. The
> current way of enabling it requires the user manually unbind the device
> from the driver, flip the temperature sampling control bit and then bind
> the device back to the driver. It would be nice if we can control this in a
> better way by reading the dt.
>
> Solution:
>         Introducing device tree binding analog,temp1-enable. If the
> flag is set, flip the temp1_en control bit on probing.
>
> Testing:
> make dt_binding_check
>
> Signed-off-by: Chu Lin <linchuyuan@google.com>
> ---
> ChangeLog v1->v2:
>  - Rename adm1272-adm1278-temp1-en to analog-temperature1-enable
>
> ChangeLog v2->v3:
>  - Rename analog-temperature1-enable analog,temp1-enable
>
>  Documentation/devicetree/bindings/hwmon/adm1275.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adm1275.txt b/Documentation/devicetree/bindings/hwmon/adm1275.txt
> index 1ecd03f3da4d..22ca5a321d5c 100644
> --- a/Documentation/devicetree/bindings/hwmon/adm1275.txt
> +++ b/Documentation/devicetree/bindings/hwmon/adm1275.txt
> @@ -15,6 +15,8 @@ Optional properties:
>
>  - shunt-resistor-micro-ohms
>         Shunt resistor value in micro-Ohm
> +- analog,temp1-enable
> +       Enable temperature sampling. This is supported on adm1272 and adm1278
>
>  Example:
>
> @@ -22,4 +24,5 @@ adm1272@10 {
>         compatible = "adi,adm1272";
>         reg = <0x10>;
>         shunt-resistor-micro-ohms = <500>;
> +       analog,temp1-enable;
>  };
> --
> 2.28.0.rc0.105.gf9edc3c819-goog
>

      reply	other threads:[~2021-05-04 23:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21  3:48 [PATCH v3] dt-bindings: hwmon: adm1272: add analog,temp1-enable binding Chu Lin
2021-05-04 23:16 ` Chu Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKCA56AziFJGnX6u5D35psboOUFZhSOGxpkb_4JaRo5mVk7fnQ@mail.gmail.com \
    --to=linchuyuan@google.com \
    --cc=belgaied@google.com \
    --cc=jasonling@google.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh+dt@kernel.org \
    --cc=zhongqil@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).