linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manish Badarkhe <badarkhe.manish@gmail.com>
To: Nicolas Saenz Julienne <nicolas.saenz@prodys.net>
Cc: sre@kernel.org, robh+dt@kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	linux-pm@vger.kernel.org,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] power: supply: add sbs-charger driver
Date: Wed, 21 Dec 2016 15:39:46 +0530	[thread overview]
Message-ID: <CAKDJKT4zFB-Q6x5davDYpzgGfkRfoFqTOaL24MQjm_=b2B-Z5Q@mail.gmail.com> (raw)
In-Reply-To: <72292f5b-3f81-f097-a87e-56b58098ff2b@prodys.net>

Hi Nicolas

On Wed, Dec 21, 2016 at 3:00 PM, Nicolas Saenz Julienne
<nicolas.saenz@prodys.net> wrote:
> Hi Manish, thanks for the interest.
>
> On 20/12/16 17:54, Manish Badarkhe wrote:
>> Hi Nicola
>>
> [...]
>>
>> Just some general comment, Can you add some more properties here to
>> know voltage and current?
>
> I assume you are mentioning reading current and voltage values. These
> properties are not supported by the sbs-charger standard. All you can do
> is set (write only) the charging current and charging voltage values.
> Yet in all the boards I've worked with it's the sbs-battery compliant
> chip that takes care of it.

thanks for clarifying me.


>> Also, can you add other properties present in charging status register
>> like POWER_FAIL, VOLTAGE_OR,
>> CURRENT_OR etc.
>
> CURRENT_OR and VOLTAGE_OR relate to wrong values in the charging
> voltage/current registers. Since the sbs-battery chip takes care of it I
> don't see any use for it.
> POWER_FAIL marks there is not enough voltage to charge the battery. I
> don't need that information so I did nothing to integrate it. Having a
> quick look at the power supply defines I don't see were it could easily fit.

thanks for clarifying me.

Regards
Manish Badarkhe

  reply	other threads:[~2016-12-21 10:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-20 15:31 [PATCH v4 0/2] power: supply: add sbs-charger driver Nicolas Saenz Julienne
2016-12-20 15:31 ` [PATCH v4 1/2] " Nicolas Saenz Julienne
2016-12-20 16:54   ` Manish Badarkhe
2016-12-21  9:30     ` Nicolas Saenz Julienne
2016-12-21 10:09       ` Manish Badarkhe [this message]
2016-12-20 15:31 ` [PATCH v4 2/2] dt-bindings: power: add bindings for sbs-charger Nicolas Saenz Julienne
2016-12-22 18:04 ` [PATCH v4 0/2] power: supply: add sbs-charger driver Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKDJKT4zFB-Q6x5davDYpzgGfkRfoFqTOaL24MQjm_=b2B-Z5Q@mail.gmail.com' \
    --to=badarkhe.manish@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.saenz@prodys.net \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).