From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751762AbbKJDJA (ORCPT ); Mon, 9 Nov 2015 22:09:00 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:33355 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727AbbKJDI7 convert rfc822-to-8bit (ORCPT ); Mon, 9 Nov 2015 22:08:59 -0500 MIME-Version: 1.0 In-Reply-To: <434305b1308b4da48f38891867e65120@EXCHCS32.ornl.gov> References: <2f66e94923a7655495165123a5efe3bd099d77bc.1446881645.git.shivanib134@gmail.com> <20151109133730.GA9390@eudyptula.hq.kempniu.pl> <434305b1308b4da48f38891867e65120@EXCHCS32.ornl.gov> Date: Tue, 10 Nov 2015 08:38:57 +0530 Message-ID: Subject: Re: [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function From: Shivani Bhardwaj To: "Simmons, James A." Cc: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= , "Drokin, Oleg" , Greg KH , "devel@driverdev.osuosl.org" , "Dilger, Andreas" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2015 at 12:48 AM, Simmons, James A. wrote: >>On Mon, Nov 9, 2015 at 7:07 PM, Michał Kępień wrote: >>>> Remove the function ll_finish_md_op_data() and replace all its calls >>>> with the standrd function ll_finish_md_op_data(). >>> >>> I believe you meant to write "standard function kfree()". >>> >> >>Yes. I am so sorry. Should I be sending the whole series again? >>Thank you >>Shivani > > Yes please redo the series. I saw Oleg's concern and I would recommend that > besides the conversion to kfree that you add comments about what is being deleted. > I.E > > /* Free struct md_op_data data*/ > kfree(...) I'll do that. Thank you