From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753061Ab2AWKOD (ORCPT ); Mon, 23 Jan 2012 05:14:03 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:33020 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752992Ab2AWKOB convert rfc822-to-8bit (ORCPT ); Mon, 23 Jan 2012 05:14:01 -0500 MIME-Version: 1.0 In-Reply-To: References: <002501ccd728$baca1010$305e3030$%jun@samsung.com> Date: Mon, 23 Jan 2012 15:43:59 +0530 Message-ID: Subject: Re: [PATCH v3 0/2] mmc: core: Support packed command feature of eMMC4.5 From: Saugata Das To: Kyungmin Park Cc: Seungwon Jeon , linux-mmc@vger.kernel.org, Chris Ball , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20 January 2012 10:05, Kyungmin Park wrote: > Hi, > > FYI: we get performance gain using packed command at write. however in > case of small size read, there are some performance drop since > protocol overhead. > In normal case, read command uses read operation only, but in case of > packed read. It sends the command to eMMC and read it. > Anyway it's good feature for eMMC v4.5. > I believe the improvement will vary depending on how many commands are packed, which will depend on use case (e.g. CPU load, rate of application read/write), file system state (e.g. fragmentation, amount of free space) etc. It will be very interesting if you can publish the details of what you have tested and your observation of different parameters related to packed command. > Acked-by: Kyungmin Park > > On 1/20/12, Seungwon Jeon wrote: >> This patch-set adds support of packed command feature >> for eMMC4.5 devices. >> >> Changes in v3: >>       - Add a variable member in mmc_host for minimum number of packed entries. >>         This value can be overrided by host. >>       - Fix a handling of error sequence. >> >> Changes in v2: >>       - Fix the packed read sequence and error handling. >>       - Apply checking the exception status for all cases with >>         the comments from Maya Erez and Sahitya Tummala. >>       - Fix preparing the packed list with the comment from Maya Erez and >> Venkatraman. >> >> >> Seungwon Jeon (2): >>       mmc: core: Add packed command feature of eMMC4.5 >>       mmc: core: Support packed command for eMMC4.5 device >> >>  drivers/mmc/card/block.c   |  469 >> +++++++++++++++++++++++++++++++++++++++++--- >>  drivers/mmc/card/queue.c   |   48 +++++- >>  drivers/mmc/card/queue.h   |   13 ++ >>  drivers/mmc/core/host.c    |    2 + >>  drivers/mmc/core/mmc.c     |   24 +++ >>  drivers/mmc/core/mmc_ops.c |    1 + >>  include/linux/mmc/card.h   |    3 + >>  include/linux/mmc/core.h   |    3 + >>  include/linux/mmc/host.h   |    4 + >>  include/linux/mmc/mmc.h    |   15 ++ >>  10 files changed, 555 insertions(+), 27 deletions(-) >> >> Best regards, >> Seungwon Jeon. >> -- >> 1.7.2.3 >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at  http://vger.kernel.org/majordomo-info.html >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html