From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: DRI Development <dri-devel@lists.freedesktop.org>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
"C, Ramalingam" <ramalingam.c@intel.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 1/4] component: Add documentation
Date: Fri, 8 Feb 2019 16:45:47 +0100 [thread overview]
Message-ID: <CAKMK7uE027rMTThQn=OkhBzmT0g0J=j_hoVG7e2hFYFv4=RDgQ@mail.gmail.com> (raw)
In-Reply-To: <20190208152911.GM23159@phenom.ffwll.local>
On Fri, Feb 8, 2019 at 4:29 PM Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Fri, Feb 08, 2019 at 12:51:23PM +0100, Greg Kroah-Hartman wrote:
> > On Fri, Feb 08, 2019 at 12:27:56AM +0100, Daniel Vetter wrote:
> > > While typing these I think doing an s/component_master/aggregate/
> > > would be useful:
> > > - it's shorter :-)
> > > - I think component/aggregate is much more meaningful naming than
> > > component/puppetmaster or something like that. At least to my
> > > English ear "aggregate" emphasizes much more the "assemble a pile of
> > > things into something bigger" aspect, and there's not really much
> > > of a control hierarchy between aggregate and constituing components.
> > >
> > > But that's way more than a quick doc typing exercise ...
> > >
> > > Thanks to Ram for commenting on an initial draft of these docs.
> > >
> > > v2: Review from Rafael:
> > > - git add Documenation/driver-api/component.rst
> > > - lots of polish to the wording + spelling fixes.
> > >
> > > v3: Review from Russell:
> > > - s/framework/helper
> > > - clarify the documentation for component_match_add functions.
> > >
> > > v4: Remove a few superflous "This".
> > >
> > > Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > Cc: "C, Ramalingam" <ramalingam.c@intel.com>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > > Cc: Rafael J. Wysocki <rafael@kernel.org>
> > > Cc: Jaroslav Kysela <perex@perex.cz>
> > > Cc: Takashi Iwai <tiwai@suse.com>
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> >
> > Thanks for doing this!
> >
> > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Thanks for reviewing (obviously includes Rafael and Russell too)!
>
> For merging I see two options:
> - All through drm-intel, but will only land in 5.2 because the feature
> cut-off has already happened for i915. So a bit awkward.
> - Topic branch with the 2 component patches plus the snd-hda/drm-i915
> patch, so that you/Takashi/drm can pull it in as needed. The drm
> component doc patch (3/4 in this series) I can pull in later on.
>
> Greg/Takashi, any preferences?
Just realized that for the mei side of this series I need a topic
branch anyway, so topic branch it is. I'll prep that so that CI can
beat on it over the w/e, and we can rebase the i915/mei series on top,
and then send out the topic pull to everyone early next week. You can
then all decide whether you need it or not.
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2019-02-08 15:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 23:27 [PATCH 1/4] component: Add documentation Daniel Vetter
2019-02-07 23:27 ` [PATCH 2/4] components: multiple components for a device Daniel Vetter
2019-02-07 23:30 ` Rafael J. Wysocki
2019-02-08 10:28 ` Russell King - ARM Linux admin
2019-02-08 15:23 ` Daniel Vetter
2019-02-08 15:36 ` Daniel Vetter
2019-02-08 11:52 ` Greg Kroah-Hartman
2019-02-07 23:27 ` [PATCH 3/4] drm/doc: document recommended component helper usage Daniel Vetter
2019-02-07 23:27 ` [PATCH 4/4] i915/snd_hdac: I915 subcomponent for the snd_hdac Daniel Vetter
2019-02-08 11:51 ` [PATCH 1/4] component: Add documentation Greg Kroah-Hartman
2019-02-08 15:29 ` Daniel Vetter
2019-02-08 15:45 ` Daniel Vetter [this message]
2019-02-18 3:31 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKMK7uE027rMTThQn=OkhBzmT0g0J=j_hoVG7e2hFYFv4=RDgQ@mail.gmail.com' \
--to=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=ramalingam.c@intel.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=rodrigo.vivi@intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).