From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759514AbdDSFAD (ORCPT ); Wed, 19 Apr 2017 01:00:03 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:33303 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759491AbdDSFAB (ORCPT ); Wed, 19 Apr 2017 01:00:01 -0400 MIME-Version: 1.0 X-Originating-IP: [212.51.149.109] In-Reply-To: <20170418191157.18517-2-eric@anholt.net> References: <20170418191157.18517-1-eric@anholt.net> <20170418191157.18517-2-eric@anholt.net> From: Daniel Vetter Date: Wed, 19 Apr 2017 06:59:59 +0200 X-Google-Sender-Auth: O2vBFZIGuEay3O-YDwTBNL-EZAg Message-ID: Subject: Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. To: Eric Anholt Cc: dri-devel , Rob Herring , Mark Rutland , "devicetree@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2017 at 9:11 PM, Eric Anholt wrote: > The FBDEV initialization would throw an error in dmesg, when we just > want to silently not initialize fbdev on a V3D-only VC4 instance. > > Signed-off-by: Eric Anholt Hm, this shouldn't be an error really, you might want to hotplug more connectors later on. What exactly complains? -Daniel > --- > drivers/gpu/drm/vc4/vc4_kms.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c > index ad7925a9e0ea..237a504f11f0 100644 > --- a/drivers/gpu/drm/vc4/vc4_kms.c > +++ b/drivers/gpu/drm/vc4/vc4_kms.c > @@ -230,10 +230,12 @@ int vc4_kms_load(struct drm_device *dev) > > drm_mode_config_reset(dev); > > - vc4->fbdev = drm_fbdev_cma_init(dev, 32, > - dev->mode_config.num_connector); > - if (IS_ERR(vc4->fbdev)) > - vc4->fbdev = NULL; > + if (dev->mode_config.num_connector) { > + vc4->fbdev = drm_fbdev_cma_init(dev, 32, > + dev->mode_config.num_connector); > + if (IS_ERR(vc4->fbdev)) > + vc4->fbdev = NULL; > + } > > drm_kms_helper_poll_init(dev); > > -- > 2.11.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch