From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F399C433EF for ; Fri, 10 Sep 2021 16:14:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 180836124D for ; Fri, 10 Sep 2021 16:14:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232835AbhIJQPO (ORCPT ); Fri, 10 Sep 2021 12:15:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231289AbhIJQO4 (ORCPT ); Fri, 10 Sep 2021 12:14:56 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40428C06139F for ; Fri, 10 Sep 2021 09:10:39 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id x10-20020a056830408a00b004f26cead745so2872462ott.10 for ; Fri, 10 Sep 2021 09:10:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jo5OwxEWWhiw1vRCZY9Md42z//D7x07LY6Hl1A6tjps=; b=a0BoFV2TX+cHGSEkivRtqdXQcXf3GOKizfSbi6dcn7QP9OoYDw1ehnFhDE/QjMj511 FCZZhv+ouEx5reHS+gkUQDH/M+ewX1aX1Xgg6XZQDp85y7pT+zngdTdq2+vS9wva64ll JzfFxb9DqiDM1q/QIF89slqZpHJyyzwVKNvPk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jo5OwxEWWhiw1vRCZY9Md42z//D7x07LY6Hl1A6tjps=; b=stRdtezLmY7cxkKF9TQ958DW7ZForZGOpGVjxrssXHomqR7k1WXkm59SvK80AJcUpr ek5fQFEZg8MBj9/esmk2fbnUBIKVR6vpp+wOnjYok3gOOIFM3q6ZDVLmAAjr25ko1mVW Ecexk3g/XRTiDgSdX9GjPfGKqreiw+UMHLqy5mNO4UA5y7a6PAmr+hQ+xv+e3T+tOkMt nasPGU4ADcCL+XmHCUmfhVhCU9LQop1fRso5B/PXKOnnYt7Rg8kiCwtaQS8Mo37WVOx6 T1J1zRXC7bBLJsdlP52tRrhSplvOY9LGYZxALDoRfOGKoiEE/Am05b6sAyvg1kRzG2l4 ByNQ== X-Gm-Message-State: AOAM533kgtAPya5q7sEYbI4FXnss44vLgeVYUV6cvHwAAgoZFNS6bf8l p6JUdVi+PdmA/WyO8pTQk5+AwmCUvPvyw7cejUY/FQ== X-Google-Smtp-Source: ABdhPJys2gnxbrHm2zi8RWfzvu1eIvi6jhZXOMYm/oQiNsIMFOEpuQ0wxhKujydoIGCLqH9b8BU5AlqILlp4u13Kfc0= X-Received: by 2002:a9d:67c1:: with SMTP id c1mr5195333otn.239.1631290238353; Fri, 10 Sep 2021 09:10:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Daniel Vetter Date: Fri, 10 Sep 2021 18:10:27 +0200 Message-ID: Subject: Re: Habanalabs Open-Source TPC LLVM compiler and SynapseAI Core library To: Greg Kroah-Hartman , dri-devel Cc: Oded Gabbay , mzuckerman@habana.ai, dsinger@habana.ai, Linus Torvalds , Dave Airlie , Jason Gunthorpe , "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Forgot to add dri-devel. On Fri, Sep 10, 2021 at 6:09 PM Daniel Vetter wrote: > > On Fri, Sep 10, 2021 at 9:58 AM Greg Kroah-Hartman > wrote: > > On Fri, Sep 10, 2021 at 10:26:56AM +0300, Oded Gabbay wrote: > > > Hi Greg, > > > > > > Following our conversations a couple of months ago, I'm happy to tell you that > > > Habanalabs has open-sourced its TPC (Tensor Processing Core) LLVM compiler, > > > which is a fork of the LLVM open-source project. > > > > > > The project can be found on Habanalabs GitHub website at: > > > https://github.com/HabanaAI/tpc_llvm > > > > > > There is a companion guide on how to write TPC kernels at: > > > https://docs.habana.ai/en/latest/TPC_User_Guide/TPC_User_Guide.html > > > > That's great news, thanks for pushing for this and releasing it all! > > Yeah this is neat. > > There's still the problem that we spent the past 2.5 years pissing off > a lot of people for an imo questionable political project, bypassing > all the technical review and expertise. Now that the political > nonsense is resolved I think we need to look at at least the technical > cleanup. The angered people are much harder to fix, so let's maybe > ignore that (or perhaps a ks topic, no idea, I'm honestly not super > motivated to rehash this entire story again). Here's what I think we > should do: > > - move drivers/misc/habanalabs under drivers/gpu/habanalabs and > review/discussions on dri-devel > - grandfather the entire current situation in as-is, it's not the only > driver we have with a funny uapi of its own (but the other driver did > manage to get their compiler into upstream llvm even, and not like 2 > years late) > - review the dma-buf stuff on dri-devel and then land it through > standard flows, not the gregk-misc bypass > - close drivers/misc backdoor for further accel driver submissions, > I'd like to focus on technical stuff in this area going forward and > not pointless exercises in bypassing due process and all that > > I expect we'll have a proper discussion what the stack should look > like with the next submission (from a different vendor maybe), that > ship kinda sailed with habanalabs. > > Cheers, Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch