From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Lee Jones <lee.jones@linaro.org>
Cc: Peilin Ye <yepeilin.cs@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] Fonts: Replace discarded const qualifier
Date: Tue, 3 Nov 2020 09:58:18 +0100 [thread overview]
Message-ID: <CAKMK7uGV10+TEWWMJod1-MRD1jkLqvOGUu4Qk9S84WJAUaB7Mg@mail.gmail.com> (raw)
In-Reply-To: <20201103085324.GL4488@dell>
On Tue, Nov 3, 2020 at 9:53 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Mon, 02 Nov 2020, Peilin Ye wrote:
>
> > From: Lee Jones <lee.jones@linaro.org>
> >
> > Commit 6735b4632def ("Fonts: Support FONT_EXTRA_WORDS macros for built-in
> > fonts") introduced the following error when building rpc_defconfig (only
> > this build appears to be affected):
> >
> > `acorndata_8x8' referenced in section `.text' of arch/arm/boot/compressed/ll_char_wr.o:
> > defined in discarded section `.data' of arch/arm/boot/compressed/font.o
> > `acorndata_8x8' referenced in section `.data.rel.ro' of arch/arm/boot/compressed/font.o:
> > defined in discarded section `.data' of arch/arm/boot/compressed/font.o
> > make[3]: *** [/scratch/linux/arch/arm/boot/compressed/Makefile:191: arch/arm/boot/compressed/vmlinux] Error 1
> > make[2]: *** [/scratch/linux/arch/arm/boot/Makefile:61: arch/arm/boot/compressed/vmlinux] Error 2
> > make[1]: *** [/scratch/linux/arch/arm/Makefile:317: zImage] Error 2
> >
> > The .data section is discarded at link time. Reinstating acorndata_8x8 as
> > const ensures it is still available after linking. Do the same for the
> > other 12 built-in fonts as well, for consistency purposes.
> >
> > Cc: <stable@vger.kernel.org>
> > Cc: Russell King <linux@armlinux.org.uk>
> > Fixes: 6735b4632def ("Fonts: Support FONT_EXTRA_WORDS macros for built-in fonts")
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > Co-developed-by: Peilin Ye <yepeilin.cs@gmail.com>
> > Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com>
> > ---
> > Changes in v2:
> > - Fix commit ID to 6735b4632def in commit message (Russell King
> > <linux@armlinux.org.uk>)
> > - Add `const` back for all 13 built-in fonts (Daniel Vetter
> > <daniel.vetter@ffwll.ch>)
> > - Add a Fixes: tag
> >
> > lib/fonts/font_10x18.c | 2 +-
> > lib/fonts/font_6x10.c | 2 +-
> > lib/fonts/font_6x11.c | 2 +-
> > lib/fonts/font_6x8.c | 2 +-
> > lib/fonts/font_7x14.c | 2 +-
> > lib/fonts/font_8x16.c | 2 +-
> > lib/fonts/font_8x8.c | 2 +-
> > lib/fonts/font_acorn_8x8.c | 2 +-
> > lib/fonts/font_mini_4x6.c | 2 +-
> > lib/fonts/font_pearl_8x8.c | 2 +-
> > lib/fonts/font_sun12x22.c | 2 +-
> > lib/fonts/font_sun8x16.c | 2 +-
> > lib/fonts/font_ter16x32.c | 2 +-
> > 13 files changed, 13 insertions(+), 13 deletions(-)
>
> LGTM.
>
> Thanks for keeping my authorship. Much appreciated.
Should I stuff this into drm-misc-fixes? Or will someone else pick
this up? Greg?
I guess drm-misc-fixes might be easiest since there's a bunch of other
fbcon/font stuff in the queue in drm-misc from Peilin.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2020-11-03 8:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 18:18 [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier Lee Jones
2020-10-31 5:09 ` Peilin Ye
2020-10-31 10:27 ` Russell King - ARM Linux admin
2020-11-01 13:11 ` Lee Jones
2020-11-02 10:23 ` Russell King - ARM Linux admin
2020-11-02 10:30 ` Russell King - ARM Linux admin
2020-11-02 16:12 ` Peilin Ye
2020-11-02 10:56 ` Daniel Vetter
2020-11-02 11:09 ` Lee Jones
2020-11-02 11:18 ` Daniel Vetter
2020-11-02 11:30 ` Lee Jones
2020-11-02 14:50 ` Daniel Vetter
2020-11-02 16:17 ` Peilin Ye
2020-11-02 16:24 ` Lee Jones
2020-11-02 16:25 ` Lee Jones
2020-11-02 16:34 ` Peilin Ye
2020-11-02 18:32 ` [PATCH v2 1/1] Fonts: " Peilin Ye
2020-11-03 8:53 ` Lee Jones
2020-11-03 8:58 ` Daniel Vetter [this message]
2020-11-03 9:15 ` Greg KH
2020-11-03 9:52 ` Daniel Vetter
2020-11-03 10:55 ` Lee Jones
2020-11-03 11:42 ` Peilin Ye
2020-11-07 5:19 ` Peilin Ye
2020-11-07 15:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uGV10+TEWWMJod1-MRD1jkLqvOGUu4Qk9S84WJAUaB7Mg@mail.gmail.com \
--to=daniel.vetter@ffwll.ch \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=stable@vger.kernel.org \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).