From: Daniel Vetter <daniel@ffwll.ch>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Dave Airlie <airlied@linux.ie>,
DRI <dri-devel@lists.freedesktop.org>,
Leo Li <sunpeng.li@amd.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Kent Russell <kent.russell@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
Ken Chalmers <ken.chalmers@amd.com>
Subject: Re: linux-next: Fixes tags need some work in the drm tree
Date: Fri, 1 Feb 2019 11:05:43 +0100 [thread overview]
Message-ID: <CAKMK7uGf7X3m3Hp1r3-RSrKvGqsJK61WAMQ7goFP_28GAieP2w@mail.gmail.com> (raw)
In-Reply-To: <20190201105736.1428c9fc@canb.auug.org.au>
On Fri, Feb 1, 2019 at 12:57 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
> a93587b31e34 ("drm/amd/display: Only get the connector state for VRR when toggled")
>
> Fixes tag
>
> Fixes: 3cc22f281318 ("drm/amdgpu: Set FreeSync state using drm VRR properties")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe instead:
>
> FIxes: bb47de736661 ("drm/amdgpu: Set FreeSync state using drm VRR properties")
>
> In commit
>
> 32e61361b82e ("drm/amd/display: Fix 64-bit division for 32-bit builds")
>
> Fixes tag
>
> Fixes: https://lists.freedesktop.org/archives/dri-devel/2018-December/201008.html
>
> has these problem(s):
>
> - No SHA1 recognised
>
> Maybe instead:
>
> Fixes: 80604e27bc9 ("drm/amd/display: Use 100 Hz precision for pipe pixel clocks")
>
> In commit
>
> c4312c27c826 ("drm/amdgpu: Cleanup 2 compiler warnings")
>
> Fixes tag
>
> Fixes: e4ae0fc drm/amdgpu: implement gfx8 post_soft_reset
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
>
> Fixes tag
>
> Fixes: 5e01c09 drm/amdgpu/gfx_v8_0: Reorder the gfx, kiq and kcq rings
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe instead:
>
> Fixes: c6064de4b734 ("drm/amdgpu/gfx_v8_0: Reorder the gfx, kiq and kcq rings test sequence")
Yeah the top 71 commits in the latest amdgpu pull got rebased, which
is a bit much. Where are we with the "direct group commit, no more
rebases" project for amd? Still stuck on CI troubles?
Another one: Is the above checker script available somewhere, could be
useful to put that into our own scripts to make sure this doesn't
happen again.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2019-02-01 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 23:57 linux-next: Fixes tags need some work in the drm tree Stephen Rothwell
2019-02-01 10:05 ` Daniel Vetter [this message]
2019-02-01 10:48 ` Stephen Rothwell
2019-02-01 20:34 ` Alex Deucher
2019-02-04 9:13 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uGf7X3m3Hp1r3-RSrKvGqsJK61WAMQ7goFP_28GAieP2w@mail.gmail.com \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ken.chalmers@amd.com \
--cc=kent.russell@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=nicholas.kazlauskas@amd.com \
--cc=sfr@canb.auug.org.au \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).