From: Daniel Vetter <daniel@ffwll.ch>
To: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/imx/dcss: fix compilation issue on 32bit
Date: Thu, 10 Sep 2020 11:57:10 +0200 [thread overview]
Message-ID: <CAKMK7uGsJcg81a_cGebBgk3pwxj4VPrFfmV5AF+5fRyK3_Pigw@mail.gmail.com> (raw)
In-Reply-To: <20200910095250.7663-1-laurentiu.palcu@oss.nxp.com>
On Thu, Sep 10, 2020 at 11:53 AM Laurentiu Palcu
<laurentiu.palcu@oss.nxp.com> wrote:
>
> When compiling for 32bit platforms, the compilation fails with:
>
> ERROR: modpost: "__aeabi_ldivmod"
> [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> ERROR: modpost: "__aeabi_uldivmod"
> [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
>
> This patch adds a dependency on ARM64 since no 32bit SoCs have DCSS, so far.
Usual way to fix this correctly is using the right division macros,
not limiting the driver to 64bit. But this works for now, would be
good to fix this properly for compile-testing and all that.
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> Reported-by: Daniel Vetter <daniel@ffwll.ch>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Please push to drm-misc-next.
-Daniel
---
> drivers/gpu/drm/imx/dcss/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig
> index 69860de8861f..2b17a964ff05 100644
> --- a/drivers/gpu/drm/imx/dcss/Kconfig
> +++ b/drivers/gpu/drm/imx/dcss/Kconfig
> @@ -3,7 +3,7 @@ config DRM_IMX_DCSS
> select IMX_IRQSTEER
> select DRM_KMS_CMA_HELPER
> select VIDEOMODE_HELPERS
> - depends on DRM && ARCH_MXC
> + depends on DRM && ARCH_MXC && ARM64
> help
> Choose this if you have a NXP i.MX8MQ based system and want to use the
> Display Controller Subsystem. This option enables DCSS support.
> --
> 2.17.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2020-09-10 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 9:52 [PATCH] drm/imx/dcss: fix compilation issue on 32bit Laurentiu Palcu
2020-09-10 9:57 ` Daniel Vetter [this message]
2020-09-10 10:21 ` Laurentiu Palcu
2020-09-10 10:24 ` Lucas Stach
2020-09-10 10:28 ` Laurentiu Palcu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uGsJcg81a_cGebBgk3pwxj4VPrFfmV5AF+5fRyK3_Pigw@mail.gmail.com \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=laurentiu.palcu@oss.nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).