From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F133C433E1 for ; Thu, 30 Jul 2020 11:35:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 164AC20656 for ; Thu, 30 Jul 2020 11:35:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="iipVaGjf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727833AbgG3LfT (ORCPT ); Thu, 30 Jul 2020 07:35:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbgG3LfS (ORCPT ); Thu, 30 Jul 2020 07:35:18 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50808C0619D2 for ; Thu, 30 Jul 2020 04:35:17 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id p25so10458285oto.6 for ; Thu, 30 Jul 2020 04:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MRzokrMc0Qm9FKeka5mjSS3X3+tAOXypP+ce1X7MQBI=; b=iipVaGjfy4vwKxkDV4BAQroSsbhnoNOfVaRbNPsPbYc617UHV3vMKacI3QuoVFW4Ym NMEfZrR2B+sQF5rf1QYFMQhm71yOP2XE0ErB0cuM7dlMVGT/r/UTqlQt9ZlRjsV3FiHj KOP0wiur98KfxTYFxbJ78Ro9HO5aYJz9EPxPI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MRzokrMc0Qm9FKeka5mjSS3X3+tAOXypP+ce1X7MQBI=; b=Rm5UIQOWg+NYjYIMCEpshm3qTWPdkkbSgzLeyN4ur0nJC/U33Pul0q+mMuZOpK8BlM 8By+EmwZ1/W19oBfAk8ukJvS1j4LfVX9ziU/5W4DY0igZDcRp5CPF2dRsMyYCGk5L6io U5K/hMZ5vlhMDPcsyxSGJdRmSah/EgCYhSCbqYIq4L84F8mGp1L7FxK9gxZnqxBXdQom R/Ow/PfqIbOptnug8ojfwMvyX7KWFYoJgOoaRJGcrxP2RzCGCAVZNLUdhJ7VNjm7bubv H62R74ol8tXPDuksNhIoxf81vlwuSI/kp4+t6ma67kUK9+bAmbxDqeZzDmCpET0zS68B kqcw== X-Gm-Message-State: AOAM533QItDQiPkEdhaCx1O0geSuIQK3TeLIv1wSKi+rtIgMNsRgvvmd wq0OFIVeS4sWKPIlvJnLc+EeKbtLcnGClH7M2p5Lcg== X-Google-Smtp-Source: ABdhPJyK3XjO3qAYxV/3DE11QmLPyeVuxGiJw5ED5uo8MdAzpo+p3AFXndZW5wHhjoS7i3OPw7tr1pOnjbzeng7wAi4= X-Received: by 2002:a9d:6052:: with SMTP id v18mr1821579otj.303.1596108916621; Thu, 30 Jul 2020 04:35:16 -0700 (PDT) MIME-Version: 1.0 References: <1596000620-4075-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> In-Reply-To: From: Daniel Vetter Date: Thu, 30 Jul 2020 13:35:05 +0200 Message-ID: Subject: Re: [PATCH] fbmem: pull fbcon_update_vcs() out of fb_set_var() To: Tetsuo Handa Cc: Greg Kroah-Hartman , Jiri Slaby , Linux Fbdev development list , Bartlomiej Zolnierkiewicz , Linux Kernel Mailing List , dri-devel , syzbot Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 30, 2020 at 1:27 PM Tetsuo Handa wrote: > > On 2020/07/30 20:16, Daniel Vetter wrote: > > Patch looks good, except ... does this compile? fbcon_update_vcs is > > defined in fbcon.h, and that doesn't seem to be included here ... > > Maybe what we want is an fb_set_var_ioctl in fbmem.c so that the fbcon > > interaction is a bit better hidden (but that's a bikeshed, feel free > > to ignore). Also I have no idea what trickery you need to compile-test > > ps3fb, that's why I'm asking :-) > > Right. I didn't prepare environment for compiling powerpc kernel. > Kernel test robot found it and I already posted V2 patch as > https://lkml.kernel.org/r/075b7e37-3278-cd7d-31ab-c5073cfa8e92@i-love.sakura.ne.jp . Excellent. It's still stuck in a queue somewhere and hasn't reached my inbox, I'll queue it up as soon as I have it. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch