From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754598AbdEGXAN (ORCPT ); Sun, 7 May 2017 19:00:13 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:33246 "EHLO mail-it0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753436AbdEGXAL (ORCPT ); Sun, 7 May 2017 19:00:11 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:5640:0:960b:2678:e223:c1c6] In-Reply-To: <3c44fef6-751a-b322-3b84-eef192012606@kernel.dk> References: <20170507171252.5149-1-ville.syrjala@linux.intel.com> <3c44fef6-751a-b322-3b84-eef192012606@kernel.dk> From: Daniel Vetter Date: Sun, 7 May 2017 19:56:29 +0200 X-Google-Sender-Auth: vSPJz2TdxiBr4Z5iB6C-CR4_Ar8 Message-ID: Subject: Re: [PATCH] drm/i915: Make vblank evade warnings optional To: Jens Axboe Cc: "Syrjala, Ville" , intel-gfx , dri-devel , Linux Kernel Mailing List , Jani Nikula , Dave Airlie , Linus Torvalds , Maarten Lankhorst Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v47N0P6O028140 On Sun, May 7, 2017 at 7:46 PM, Jens Axboe wrote: > On 05/07/2017 11:12 AM, ville.syrjala@linux.intel.com wrote: >> From: Ville Syrjälä >> >> Add a new Kconfig option to enable/disable the extra warnings >> from the vblank evade code. For now we'll keep the warning >> about an actually missed vblank always enabled as that can have >> an actual user visible impact. But if we miss the deadline >> othrwise there's no real need to bother the user with that. >> We'll want these warnings enabled during development however >> so that we can catch regressions. >> >> Based on the reports it looks like this is still very easy >> to hit on SKL, so we have more work ahead of us to optimize >> the crtiical section further. > > Shouldn't it just be a debug printk or something instead, so that normal > people don't see it, but the folks that turn on debugging can get the > info they need? Seems silly to add a kconfig option for this. I guess we could keep it as debug for users, but we want to make this a hard failure on our CI machines. Kconfig knob is the easiest to roll out to all machines. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch