From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752976AbdHBKDV (ORCPT ); Wed, 2 Aug 2017 06:03:21 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:34586 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752904AbdHBKCv (ORCPT ); Wed, 2 Aug 2017 06:02:51 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:5640:0:960b:2678:e223:c1c6] In-Reply-To: <20170802093826.3703737-1-arnd@arndb.de> References: <20170802093826.3703737-1-arnd@arndb.de> From: Daniel Vetter Date: Wed, 2 Aug 2017 12:02:50 +0200 Message-ID: Subject: Re: [PATCH] fbcon: mark dummy functions 'inline' To: Arnd Bergmann Cc: Bartlomiej Zolnierkiewicz , Sean Paul , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 2, 2017 at 11:38 AM, Arnd Bergmann wrote: > The newly introduced fb_console_init/exit declarations have a > dummy alternative that is marked 'static' in the header but not > inline, leading to a warning whenever the header gets included: > > In file included from drivers/video/fbdev/core/fbmem.c:35:0: > include/linux/fbcon.h:9:13: error: 'fb_console_exit' defined but not used [-Werror=unused-function] > > This adds the intended 'inline'. > > Fixes: 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev") > Signed-off-by: Arnd Bergmann Reviewed-by: Daniel Vetter > --- > include/linux/fbcon.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/fbcon.h b/include/linux/fbcon.h > index 0fac6305d51c..f68a7db14165 100644 > --- a/include/linux/fbcon.h > +++ b/include/linux/fbcon.h > @@ -5,8 +5,8 @@ > void __init fb_console_init(void); > void __exit fb_console_exit(void); > #else > -static void fb_console_init(void) {} > -static void fb_console_exit(void) {} > +static inline void fb_console_init(void) {} > +static inline void fb_console_exit(void) {} > #endif > > #endif /* _LINUX_FBCON_H */ > -- > 2.9.0 > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch