From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89AE1C4742C for ; Mon, 2 Nov 2020 14:51:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B84A2084C for ; Mon, 2 Nov 2020 14:51:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="ccGygpiP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726113AbgKBOvD (ORCPT ); Mon, 2 Nov 2020 09:51:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726031AbgKBOvC (ORCPT ); Mon, 2 Nov 2020 09:51:02 -0500 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DD15C061A04 for ; Mon, 2 Nov 2020 06:51:02 -0800 (PST) Received: by mail-oi1-x243.google.com with SMTP id w145so9234051oie.9 for ; Mon, 02 Nov 2020 06:51:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wZFcGmt2DZV2S1ETLPD5EyGoAl6DAcImG9s5mz7KKfo=; b=ccGygpiPnmvZMIboi3y07+KmnQkah7ON/Daac0w618bN4cW4vVuTgAcBQ9NY3EowVw nEsQTAAlQ79JcJ3qHgkvTP28qG7D0wcwgAMN/LKOzq8lo7ahPZtOQs2Lf3tg9h2cdBHj JxZeWSRiTiJlhDyLMAcAcsQwC7243TDVOikOc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wZFcGmt2DZV2S1ETLPD5EyGoAl6DAcImG9s5mz7KKfo=; b=aZRq7Nu1qax2VZIK3H6j1SmR9jsvbq5Kr/caxSyK9Dgo8vZ3oKrhaTnkjR3j234P4d 94aJBYFFWzau3Xnb7bR7RpHhzr1suuSM0sgY4LucJ44p1aS2tEMOhUyB2ZMzHDC/TU/v GXO1ZHL0bHUj735wvEhqiLGOQ05rtKWe7sHqA8vhTZ9abQOqyTc/RGiQqEBtvgjQlWL/ 0+y86I9WhUGgQvS22KRGZJ/ZhBLCiGasFvRcGPIthWhrjWclIs3fQblmTpoZf0D/exOA nU61pUDZsVheotKTnIgD2xEmUjksXxLB+KLrvAVKm5CFKY40tqZojsKgX/+bBMwkXKmp SGrw== X-Gm-Message-State: AOAM533vcNZ66kQ2koUkucaxz/0qJcm31ypRRmcWwJ1+Pfa+VNkz60OS vEM4ldC+o7k9ClDPauQwzXgV+9j31n+D9E+cKW4Umg== X-Google-Smtp-Source: ABdhPJx+WNBcNZfK2XNCkFJ/n4r/3tlXepzMqj1UT19n16EAqTaPayKRlKJhUszNDgW4Jf7XHTHibvs59WYDzXaDaXc= X-Received: by 2002:aca:cc01:: with SMTP id c1mr10429535oig.128.1604328661316; Mon, 02 Nov 2020 06:51:01 -0800 (PST) MIME-Version: 1.0 References: <20201030181822.570402-1-lee.jones@linaro.org> <20201102110916.GK4127@dell> <20201102113034.GL4127@dell> In-Reply-To: <20201102113034.GL4127@dell> From: Daniel Vetter Date: Mon, 2 Nov 2020 15:50:49 +0100 Message-ID: Subject: Re: [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier To: Lee Jones Cc: Greg KH , Peilin Ye , Linux ARM , Linux Kernel Mailing List , stable , Russell King Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 2, 2020 at 12:30 PM Lee Jones wrote: > > On Mon, 02 Nov 2020, Daniel Vetter wrote: > > > On Mon, Nov 2, 2020 at 12:09 PM Lee Jones wrote: > > > > > > On Mon, 02 Nov 2020, Daniel Vetter wrote: > > > > > > > On Fri, Oct 30, 2020 at 7:18 PM Lee Jones wrote: > > > > > > > > > > Commit 09e5b3fd5672 ("Fonts: Support FONT_EXTRA_WORDS macros for > > > > > built-in fonts") introduced the following error when building > > > > > rpc_defconfig (only this build appears to be affected): > > > > > > > > > > `acorndata_8x8' referenced in section `.text' of arch/arm/boot/compressed/ll_char_wr.o: > > > > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > > > > `acorndata_8x8' referenced in section `.data.rel.ro' of arch/arm/boot/compressed/font.o: > > > > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > > > > make[3]: *** [/scratch/linux/arch/arm/boot/compressed/Makefile:191: arch/arm/boot/compressed/vmlinux] Error 1 > > > > > make[2]: *** [/scratch/linux/arch/arm/boot/Makefile:61: arch/arm/boot/compressed/vmlinux] Error 2 > > > > > make[1]: *** [/scratch/linux/arch/arm/Makefile:317: zImage] Error 2 > > > > > > > > > > The .data section is discarded at link time. Reinstating > > > > > acorndata_8x8 as const ensures it is still available after linking. > > > > > > > > > > Cc: > > > > > Cc: Russell King > > > > > Signed-off-by: Lee Jones > > > > > > > > Shouldn't we add the const to all of them, for consistency? > > > > > > The thought did cross my mind. However, I do not see any further > > > issues which need addressing. Nor do I have any visibility into what > > > issues may be caused by doing so. The only thing I know for sure is > > > that this patch fixes the compile error pertained to in the commit > > > message, and I'd like for this fix to be as atomic as possible, as > > > it's designed to be routed through the Stable/LTS trees. > > > > The trouble is that if we only make one of them const, then it'll take > > so much longer to hit any issues due to code not handling this > > correctly. Being consistent with all fonts sounds like the best > > approach. > > > > And the original patch that lost the const for the additional data > > also went through cc: stable for all fonts together. So that shouldn't > > be the hold-up. > > My plan was to keep the fix as simple as possible. > > This is only an issue due to the odd handling of the compressed Arm > image which exclusively references 'acorndata_8x8' and discards it's > .data section. > > I am happy to go with the majority on this though. > > Does anyone else have an opinion? Oh I don't want to hold up the fix, I'm just semi desperately looking for people who care beyond "this is the most minimal thing for my use case" since this entire area is orphaned. With the other things fixed feel free to smash my ack onto this. Maybe Peilin is going to include the full re-cosntification in a cleanup series, dunno. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch