From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752862AbcD1SCI (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Apr 2016 14:02:08 -0400
Received: from mail-oi0-f41.google.com ([209.85.218.41]:34534 "EHLO
	mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752693AbcD1SCG convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Apr 2016 14:02:06 -0400
MIME-Version: 1.0
X-Originating-IP: [2a02:168:56b5:0:ac27:b86c:7764:9429]
In-Reply-To: <20160428175525.GA3502@joana>
References: <20160426174045.GC4329@intel.com>
	<20160426182346.GC2558@phenom.ffwll.local>
	<20160426185506.GH4329@intel.com>
	<20160426200505.GD2558@phenom.ffwll.local>
	<571FD402.6050407@google.com>
	<CAPj87rOfhDr14xFCH1A+BM3u_EfS66cmSTXcs32PUJrhH8nfLg@mail.gmail.com>
	<20160428143644.GA3496@joana>
	<20160428165619.GD4329@intel.com>
	<CAKMK7uGLL3MQ0ff+nVGhKMEQKJNhpC3C4g1iYSO1JfKfiMy6ag@mail.gmail.com>
	<20160428175124.GG4329@intel.com>
	<20160428175525.GA3502@joana>
Date: Thu, 28 Apr 2016 20:02:05 +0200
X-Google-Sender-Auth: VP33DghLQrzO3l3du1hEzvvIaqE
Message-ID: <CAKMK7uHr9-JFdGt_gofzHaNZYjp8UWpHtZjP7CGaSGSi5_3=7w@mail.gmail.com>
Subject: Re: [RFC v2 5/8] drm/fence: add in-fences support
From: Daniel Vetter <daniel@ffwll.ch>
To: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Cc: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        Gustavo Padovan <gustavo@padovan.org>,
        Daniel Stone <daniel@fooishbar.org>,
        Greg Hackmann <ghackmann@google.com>,
        Daniel Stone <daniels@collabora.com>,
        Riley Andrews <riandrews@android.com>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        John Harrison <John.C.Harrison@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 28, 2016 at 7:55 PM, Gustavo Padovan
<gustavo.padovan@collabora.co.uk> wrote:
> 2016-04-28 Ville Syrjälä <ville.syrjala@linux.intel.com>:
>
>> On Thu, Apr 28, 2016 at 07:43:16PM +0200, Daniel Vetter wrote:
>> > On Thu, Apr 28, 2016 at 6:56 PM, Ville Syrjälä
>> > <ville.syrjala@linux.intel.com> wrote:
>> > >>  - better for tracing, can identify the buffer/fence promptly
>> > >
>> > > Can fences be reused somehow while still attached to a plane, or ever?
>> > > That might cause some oddness if you, say, leave a fence attached to one
>> > > plane and then do a modeset on another crtc perhaps which needs to turn
>> > > the first crtc off+on to reconfigure something.
>> >
>> > Fences auto-disappear of course and don't stick around when you
>> > duplicate the drm_plane_state again. I still don't really get the real
>> > concerns though ...
>>
>> Properties that magically change values shouldn't exist IMO. I guess if
>> you could have write-only properties or something it migth be sensible?
>
> We can just not return FENCE_FD on get_props, that would make it
> write-only.

We do actually return a value for get_props, but it's -1 which for fds
means "no fd". That's to make sure userspace can save&restore any prop
without causing harm.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch