linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Edwin Peer <edwin.peer@broadcom.com>
To: Zhang Changzhong <zhangchangzhong@huawei.com>
Cc: Michael Chan <michael.chan@broadcom.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] bnxt_en: fix error return code in bnxt_init_one()
Date: Thu, 19 Nov 2020 10:53:47 -0800	[thread overview]
Message-ID: <CAKOOJTy8AnrX9N51G1C73+G-7pLaip_Vt1FBk44RRQzDec9Y7w@mail.gmail.com> (raw)
In-Reply-To: <1605701851-20270-1-git-send-email-zhangchangzhong@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

On Wed, Nov 18, 2020 at 4:17 AM Zhang Changzhong
<zhangchangzhong@huawei.com> wrote:

> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: c213eae8d3cd ("bnxt_en: Improve VF/PF link change logic.")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 7c21aaa8..092775e 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -12674,6 +12674,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>                                 create_singlethread_workqueue("bnxt_pf_wq");
>                         if (!bnxt_pf_wq) {
>                                 dev_err(&pdev->dev, "Unable to create workqueue.\n");
> +                               rc = -ENOMEM;
>                                 goto init_err_pci_clean;
>                         }
>                 }
> --

Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>

Regards,
Edwin Peer

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4160 bytes --]

  reply	other threads:[~2020-11-19 18:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18 12:17 Zhang Changzhong
2020-11-19 18:53 ` Edwin Peer [this message]
2020-11-20  5:50   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKOOJTy8AnrX9N51G1C73+G-7pLaip_Vt1FBk44RRQzDec9Y7w@mail.gmail.com \
    --to=edwin.peer@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=zhangchangzhong@huawei.com \
    --subject='Re: [PATCH net] bnxt_en: fix error return code in bnxt_init_one()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).