From: Daniel Colascione <dancol@google.com>
To: Christian Brauner <christian@brauner.io>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Jann Horn <jannh@google.com>, Andy Lutomirski <luto@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>, Aleksa Sarai <cyphar@cyphar.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Tim Murray <timmurray@google.com>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] proc: allow killing processes via file descriptors
Date: Sun, 18 Nov 2018 08:03:15 -0800 [thread overview]
Message-ID: <CAKOZuet2E8fwwx1kQftjCGJ2w5T4LS38yfr1kbMUK_PG3ffNHg@mail.gmail.com> (raw)
In-Reply-To: <20181118111751.6142-1-christian@brauner.io>
On Sun, Nov 18, 2018 at 3:17 AM, Christian Brauner <christian@brauner.io> wrote:
> +static int proc_tgid_open(struct inode *inode, struct file *file)
> +{
> + /* grab reference to struct pid */
> + file->private_data = get_pid(proc_pid(inode));
Why grab another reference to the struct pid when the inode already has one?
next prev parent reply other threads:[~2018-11-18 16:03 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 11:17 [PATCH] proc: allow killing processes via file descriptors Christian Brauner
2018-11-18 13:59 ` Daniel Colascione
2018-11-18 15:38 ` Andy Lutomirski
2018-11-18 15:53 ` Daniel Colascione
2018-11-18 16:17 ` Andy Lutomirski
2018-11-18 16:29 ` Daniel Colascione
2018-11-18 17:13 ` Andy Lutomirski
2018-11-18 17:17 ` Daniel Colascione
2018-11-18 17:43 ` Eric W. Biederman
2018-11-18 17:45 ` Andy Lutomirski
2018-11-18 17:56 ` Daniel Colascione
2018-11-18 16:33 ` Randy Dunlap
2018-11-18 16:48 ` Daniel Colascione
2018-11-18 17:09 ` Andy Lutomirski
2018-11-18 17:24 ` Daniel Colascione
2018-11-18 17:42 ` Andy Lutomirski
2018-11-18 17:51 ` Daniel Colascione
2018-11-18 18:28 ` Andy Lutomirski
2018-11-18 18:43 ` Daniel Colascione
2018-11-18 19:05 ` Aleksa Sarai
2018-11-18 19:44 ` Daniel Colascione
2018-11-18 20:15 ` Christian Brauner
2018-11-18 20:21 ` Daniel Colascione
2018-11-18 20:28 ` Andy Lutomirski
2018-11-18 20:32 ` Daniel Colascione
2018-11-19 1:43 ` Andy Lutomirski
2018-11-18 20:43 ` Christian Brauner
2018-11-18 20:54 ` Daniel Colascione
2018-11-18 21:23 ` Christian Brauner
2018-11-18 21:30 ` Christian Brauner
2018-11-19 0:31 ` Daniel Colascione
2018-11-19 0:40 ` Christian Brauner
2018-11-19 0:09 ` Aleksa Sarai
2018-11-19 0:53 ` Daniel Colascione
2018-11-19 1:16 ` Daniel Colascione
2018-11-19 16:13 ` Dmitry Safonov
2018-11-19 16:26 ` [PATCH] proc: allow killing processes via file descriptors (Larger pids) Eric W. Biederman
2018-11-19 16:27 ` [PATCH] proc: allow killing processes via file descriptors Daniel Colascione
2018-11-19 20:21 ` Aleksa Sarai
2018-11-19 2:47 ` Al Viro
2018-11-19 3:01 ` Andy Lutomirski
2018-11-18 17:41 ` Christian Brauner
2018-11-18 17:44 ` Andy Lutomirski
2018-11-18 18:07 ` Daniel Colascione
2018-11-18 18:15 ` Andy Lutomirski
2018-11-18 18:31 ` Daniel Colascione
2018-11-18 19:24 ` Christian Brauner
2018-11-19 0:08 ` Aleksa Sarai
2018-11-19 1:14 ` Daniel Colascione
2018-11-18 16:03 ` Daniel Colascione [this message]
2018-11-19 10:56 ` kbuild test robot
2018-11-19 14:15 ` David Laight
2018-11-19 15:49 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKOZuet2E8fwwx1kQftjCGJ2w5T4LS38yfr1kbMUK_PG3ffNHg@mail.gmail.com \
--to=dancol@google.com \
--cc=akpm@linux-foundation.org \
--cc=christian@brauner.io \
--cc=cyphar@cyphar.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=serge@hallyn.com \
--cc=timmurray@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).