From: Daniel Colascione <dancol@google.com>
To: Christian Brauner <christian@brauner.io>
Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>, Jann Horn <jannh@google.com>,
Jann Horn <jann@thejh.net>,
Jonathan Kowalski <bl0pbl33p@gmail.com>,
Android Kernel Team <kernel-team@android.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Michal Hocko <mhocko@suse.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Serge Hallyn <serge@hallyn.com>, Shuah Khan <shuah@kernel.org>,
Sandeep Patil <sspatil@google.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Suren Baghdasaryan <surenb@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tim Murray <timmurray@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Tycho Andersen <tycho@tycho.ws>
Subject: Re: [PATCH v1 2/2] Add selftests for pidfd polling
Date: Thu, 25 Apr 2019 15:07:48 -0700 [thread overview]
Message-ID: <CAKOZueuPeqnWVCv8NnQNyStWBQLybkr2qqtfQ0MjzsfSQDymzg@mail.gmail.com> (raw)
In-Reply-To: <20190425212917.yotnir4uqgpnh764@brauner.io>
On Thu, Apr 25, 2019 at 2:29 PM Christian Brauner <christian@brauner.io> wrote:
> This timing-based testing seems kinda odd to be honest. Can't we do
> something better than this?
Agreed. Timing-based tests have a substantial risk of becoming flaky.
We ought to be able to make these tests fully deterministic and not
subject to breakage from odd scheduling outcomes. We don't have
sleepable events for everything, granted, but sleep-waiting on a
condition with exponential backoff is fine in test code. In general,
if you start with a robust test, you can insert a sleep(100) anywhere
and not break the logic. Violating this rule always causes pain sooner
or later.
Other thoughts: IMHO, using poll(2) instead of epoll would simplify
the test code, and I think we can get away with calling
pthread_exit(3) instead of SYS_exit.
next prev parent reply other threads:[~2019-04-25 22:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 19:00 [PATCH v1 1/2] Add polling support to pidfd Joel Fernandes (Google)
2019-04-25 19:00 ` [PATCH v1 2/2] Add selftests for pidfd polling Joel Fernandes (Google)
2019-04-25 20:00 ` Tycho Andersen
2019-04-26 13:47 ` Joel Fernandes
2019-04-25 21:29 ` Christian Brauner
2019-04-25 22:07 ` Daniel Colascione [this message]
2019-04-26 17:26 ` Joel Fernandes
2019-04-26 19:35 ` Daniel Colascione
2019-04-26 20:31 ` Joel Fernandes
2019-04-26 13:42 ` Joel Fernandes
2019-04-25 22:24 ` [PATCH v1 1/2] Add polling support to pidfd Christian Brauner
2019-04-26 14:23 ` Joel Fernandes
2019-04-26 15:21 ` Christian Brauner
2019-04-26 15:31 ` Christian Brauner
2019-04-28 16:24 ` Oleg Nesterov
2019-04-29 14:02 ` Joel Fernandes
2019-04-29 14:07 ` Joel Fernandes
2019-04-29 14:25 ` Oleg Nesterov
2019-04-29 14:20 ` Oleg Nesterov
2019-04-29 16:32 ` Joel Fernandes
2019-04-30 11:53 ` Oleg Nesterov
2019-04-30 12:07 ` Oleg Nesterov
2019-04-30 15:49 ` Joel Fernandes
2019-04-26 14:58 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKOZueuPeqnWVCv8NnQNyStWBQLybkr2qqtfQ0MjzsfSQDymzg@mail.gmail.com \
--to=dancol@google.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bl0pbl33p@gmail.com \
--cc=christian@brauner.io \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=jann@thejh.net \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=serge@hallyn.com \
--cc=sfr@canb.auug.org.au \
--cc=shuah@kernel.org \
--cc=sspatil@google.com \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=timmurray@google.com \
--cc=torvalds@linux-foundation.org \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).