Re: [PATCH 3/6] gpio: Add Delta TN48M CPLD GPIO driver

From: Luka Perkov <luka.perkov@sartura.hr>
To: Michael Walle <michael@walle.cc>
Cc: "Rob Herring" <robh@kernel.org>,
	"Robert Marko" <robert.marko@sartura.hr>,
	lee.jones@linaro.org, linus.walleij@linaro.org,
	bgolaszewski@baylibre.com, jdelvare@suse.com, linux@roeck-us.net,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-hwmon@vger.kernel.org,
	"Jonathan Polom" <jmp@epiphyte.org>,
	"Paul Menzel" <pmenzel@molgen.mpg.de>,
	"Donald Buczek" <buczek@molgen.mpg.de>,
	"CLEMENT.CHANG 張弘慶" <CLEMENT.CHANG@deltaww.com>,
	upstream-wg@lists.dent.dev
Subject: Re: [PATCH 3/6] gpio: Add Delta TN48M CPLD GPIO driver
Date: Thu, 6 May 2021 19:21:17 +0200	[thread overview]
Message-ID: <CAKQ-cribKLfiZqTyBe_OtPzKGk5M2_8+0ov-D4-hTei5aouDtw@mail.gmail.com> (raw)
In-Reply-To: <3905879e67d50d6a7f73fcd83982c052@walle.cc>

Hello Michael,

On Thu, May 6, 2021 at 6:40 PM Michael Walle <michael@walle.cc> wrote:
>
> Am 2021-05-06 16:00, schrieb Rob Herring:
> > On Fri, Apr 30, 2021 at 02:35:08PM +0200, Robert Marko wrote:
> >> Delta TN48M CPLD is used as a GPIO expander for the SFP GPIOs.
> >>
> >> It is a mix of input only and output only pins.
> >>
> >> Since there is no logical GPIO numbering arbitrary one is used
> >> along dt-bindings to make it humanly readable.
> >>
> >> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> >> ---
> >>  drivers/gpio/Kconfig      |  12 +++
> >>  drivers/gpio/Makefile     |   1 +
> >>  drivers/gpio/gpio-tn48m.c | 191
> >> ++++++++++++++++++++++++++++++++++++++
> >>  drivers/mfd/tn48m-cpld.c  |   6 +-
> >>  include/linux/mfd/tn48m.h |   3 +
> >>  5 files changed, 212 insertions(+), 1 deletion(-)
> >>  create mode 100644 drivers/gpio/gpio-tn48m.c
> >
> >
> >> +static const struct platform_device_id tn48m_gpio_id_table[] = {
> >> +    { "delta,tn48m-gpio", },
> >
> > Looks like a compatible, but is not. I think you can drop this and just
> > use 'tm48m-gpio' (the driver name).
>
> I'm just curious, why isn't the vendor included here (as there
> might be a chance for name clashes in the future).

I'm looping in Clement from Delta as well as the Upstream Working
Group from DENT [0].

Thanks,

Luka

[0] https://dent.dev/