From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758169AbcGKK3T (ORCPT ); Mon, 11 Jul 2016 06:29:19 -0400 Received: from mail-vk0-f68.google.com ([209.85.213.68]:35436 "EHLO mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752511AbcGKK3R convert rfc822-to-8bit (ORCPT ); Mon, 11 Jul 2016 06:29:17 -0400 MIME-Version: 1.0 In-Reply-To: <1606219.BzcByuFgJm@wuerfel> References: <1468135649-19980-1-git-send-email-vw@iommu.org> <4765191.NGpMC1JR46@wuerfel> <578361B5.7010803@iommu.org> <1606219.BzcByuFgJm@wuerfel> From: Wan ZongShun Date: Mon, 11 Jul 2016 18:28:57 +0800 Message-ID: Subject: Re: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900 To: Arnd Bergmann Cc: Wan Zongshun , linux-arm-kernel , Russell King , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Jason Cooper , Daniel Lezcano , linux-kernel , p.zabel@pengutronix.de, Thomas Gleixner Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-07-11 18:24 GMT+08:00 Arnd Bergmann : > On Monday, July 11, 2016 5:07:01 PM CEST Wan Zongshun wrote: >> >> On 2016年07月11日 16:03, Arnd Bergmann wrote: >> > On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: >> >> + ret = of_property_read_string(np, "compatible", &soc_dev_attr->soc_id); >> >> + if (ret) >> >> return -EINVAL; >> >> + >> >> + soc_dev_attr->machine = "NUC900EVB"; >> >> + soc_dev_attr->family = "NUC900"; >> >> + soc_dev = soc_device_register(soc_dev_attr); >> >> + if (IS_ERR(soc_dev)) { >> >> + kfree(soc_dev_attr); >> >> + return -ENODEV; >> >> + } >> >> + >> >> + ret = regmap_read(syscon_regmap, GCR_CHIPID, &nuc900_chipid); >> >> + if (ret) >> >> + return -ENODEV; >> >> + >> >> + device_create_file(soc_device_to_device(soc_dev), &nuc900_chipid_attr); >> >> + device_create_file(soc_device_to_device(soc_dev), &nuc900_version_attr); >> >> + >> >> + dev_info(&pdev->dev, "Nuvoton Chip ID: 0x%x, Version ID:0x%x\n", >> >> + nuc900_chipid & GCR_CHIPID_MASK, >> >> + (nuc900_chipid >> 24) & 0xff); >> > >> > I'm still a bit unsure about the set of attributes here. >> > >> > - The "soc_id" is read from the device tree from the field that contains >> > the board name, I think for consistency you should try to map the >> > GCR_CHIPID to the name of the SoC and assign that here >> >> I will try to get chipid and map it to soc name like: “nuc970”, "nuc910". >> >> And I will set this soc name to soc_id, ok? > > Ok. Maybe I also can set versionid as soc name partly, like nuc970-version1,nuc970-version2? and then set the to soc_id, make sense? > >> > - The "machine" is hardcoded to "NUC900EVB", which in turn looks like >> > a particular board but not the one you are running on. Maybe read >> > that from the DT instead? >> >> Should I read nuc970-evb.dts's "model" or "compatible" properties? > > I think "model" is best here, but see what the others do. > > Arnd > -- --- Vincent Wan(Zongshun) www.mcuos.com