From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC555C4338F for ; Fri, 6 Aug 2021 10:19:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A87F660E97 for ; Fri, 6 Aug 2021 10:19:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245042AbhHFKTI (ORCPT ); Fri, 6 Aug 2021 06:19:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245012AbhHFKTD (ORCPT ); Fri, 6 Aug 2021 06:19:03 -0400 Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AD96C061799; Fri, 6 Aug 2021 03:18:48 -0700 (PDT) Received: by mail-yb1-xb2e.google.com with SMTP id w17so14224036ybl.11; Fri, 06 Aug 2021 03:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=LzEtfxryBMdUSVfN39cmcYQbMbUOl3wT0TLgCQg+7nU=; b=n/VEjbsrp/jmlTJBuiaAL+/o7MmspX6tZ4MUlXNkn99axHY7v0XRq5WcbEy/e6XcUM rujMBDwQF4aeCDdTLF7UxPMuUoDSD7iZ1NLR86jYGFdbxU9AuujIyu62Px+mRxx8aH3M AJzvDXo0KiDXSC3lKdPnAjuOZqiuDLXNpu+9/zvWauH1ayGta/4B7yhZfO6P0kA2CsBC 3Q0x8o+94tu7gh3LXGVnOWaKwxBwsasHf3aneIeMT+ElnkH6S82HeFJiweGvtWvJVUtI 0bzkpZtEyzKSDEYZjGE13pMZdB8YHSVt/q/LN0M6u55O4azW4Bb4FZQR5ATOfX/bcS0D /ICQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=LzEtfxryBMdUSVfN39cmcYQbMbUOl3wT0TLgCQg+7nU=; b=TzFJVlo7NYNXTuzoarMr0WLu6gFTqi9OLI75TQD3UUKSO5itRsOKxSQO+1Wy1T6870 xXbcTQfnwGO5cyHm8aNCHmwW/wmHY35Ip7hmHk385x992CabJztcv8kP/QQLfngEOPoK Mm/aT/L8cDlCjvac7YCBIQmMWXF16mtmKY+FhKb/GqkzONNqyf/AWV9v6b6UHH+3G9Mk 3LLBXiWvL8w929FZrUX9QrjB0pzAMm9mytyIPNx0QOf40eHjctxE4pYN3zzOlGIwXgIQ 6jpfes279YneJqZUdPK+pgfvrj1qOybU7Ej2+5+sNvD1ttMlg7qKYTLPNs94tXEedb+J oumg== X-Gm-Message-State: AOAM531l1cZ/VQ729wQA2xDOsVNPODhLLrE6Ky5j4AnU6ksd9MgWA0HC BpkdvQIt5srOsx/yxjKq5ZYKyGAkRfBMQlNrZI0ALs9dxt0= X-Google-Smtp-Source: ABdhPJyF6mGCLqWiOgPVDpAIAG12HTcwQD2KqRYPDACH+OUl1Ie1xlU7VOGs5wy87t1BKMkjWb40SZgKYfMn0//vnGA= X-Received: by 2002:a25:8b86:: with SMTP id j6mr11295871ybl.470.1628245127476; Fri, 06 Aug 2021 03:18:47 -0700 (PDT) MIME-Version: 1.0 From: Lukas Bulwahn Date: Fri, 6 Aug 2021 12:18:36 +0200 Message-ID: Subject: Reference to non-existing DYNAMIC_FTRACE_WITH_ARGS To: "Steven Rostedt (VMware)" Cc: live-patching@vger.kernel.org, Linux Kernel Mailing List , Ingo Molnar , Josh Poimboeuf , Petr Mladek , Joe Lawrence , Jiri Kosina , Miroslav Benes , kernel-janitors Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steven, Commit 2860cd8a2353 ("livepatch: Use the default ftrace_ops instead of REGS when ARGS is available") adds a dependency on a non-existing config DYNAMIC_FTRACE_WITH_ARGS, see diff: diff --git a/kernel/livepatch/Kconfig b/kernel/livepatch/Kconfig index 54102deb50ba..53d51ed619a3 100644 --- a/kernel/livepatch/Kconfig +++ b/kernel/livepatch/Kconfig @@ -6,7 +6,7 @@ config HAVE_LIVEPATCH config LIVEPATCH bool "Kernel Live Patching" - depends on DYNAMIC_FTRACE_WITH_REGS + depends on DYNAMIC_FTRACE_WITH_REGS || DYNAMIC_FTRACE_WITH_ARGS depends on MODULES depends on SYSFS depends on KALLSYMS_ALL Did you intend to depend on the existing "HAVE_DYNAMIC_FTRACE_WITH_ARGS" here? Or did you intend to add a new config DYNAMIC_FTRACE_WITH_ARGS analogously to DYNAMIC_FTRACE_WITH_REGS as defined in ./kernel/trace/Kconfig (see below)? config DYNAMIC_FTRACE_WITH_REGS def_bool y depends on DYNAMIC_FTRACE depends on HAVE_DYNAMIC_FTRACE_WITH_REGS I am happy to provide a patch, once I understand what was intended here. Lukas