From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
netfilter-devel@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>,
coreteam@netfilter.org,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: Suspicious pattern for use of function xt_register_template()
Date: Mon, 23 Aug 2021 22:28:45 +0200 [thread overview]
Message-ID: <CAKXUXMwZo+HixV+zYWSNvTX0yJNXaFrxCF9hOJ-77upP8qKS0g@mail.gmail.com> (raw)
In-Reply-To: <20210823191033.GA23869@breakpoint.cc>
On Mon, Aug 23, 2021 at 9:10 PM Florian Westphal <fw@strlen.de> wrote:
>
> Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> > Dear Florian, dear netfilter maintainers,
> >
> > Commit fdacd57c79b ("netfilter: x_tables: never register tables by
> > default") on linux-next
> > introduces the function xt_register_template() and in all cases but
> > one, the calls to that function are followed by:
> >
> > if (ret < 0)
> > return ret;
> >
> > All these checks were also added with the commit above.
> >
> > In the one case, for iptable_mangle_init() in
> > ./net/ipv4/netfilter/iptable_mangle.c, this pattern was not followed.
>
> Thats a bug, the error test is missing.
I send out a patch addressing the issue, please pick it:
https://lore.kernel.org/lkml/20210823202729.2009-1-lukas.bulwahn@gmail.com/
Thanks,
Lukas
prev parent reply other threads:[~2021-08-23 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 17:01 Suspicious pattern for use of function xt_register_template() Lukas Bulwahn
2021-08-23 19:10 ` Florian Westphal
2021-08-23 20:28 ` Lukas Bulwahn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKXUXMwZo+HixV+zYWSNvTX0yJNXaFrxCF9hOJ-77upP8qKS0g@mail.gmail.com \
--to=lukas.bulwahn@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).