From: Namjae Jeon <linkinjeon@gmail.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: akpm@linux-foundation.org, bfields@fieldses.org,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
Namjae Jeon <namjae.jeon@samsung.com>,
Ravishankar N <ravi.n1@samsung.com>,
Amit Sahrawat <a.sahrawat@samsung.com>
Subject: Re: [PATCH v3 2/5] fat: allocate persistent inode numbers
Date: Mon, 24 Sep 2012 13:11:11 +0900 [thread overview]
Message-ID: <CAKYAXd-6k7=RmrweR=wTOET50hy8Y7LokCSe1c2JtYd7pzPmsQ@mail.gmail.com> (raw)
In-Reply-To: <87lig28fak.fsf@devron.myhome.or.jp>
2012/9/22, OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>:
> Namjae Jeon <linkinjeon@gmail.com> writes:
>
>> - inode->i_ino = iunique(sb, MSDOS_ROOT_INO);
>> + if (MSDOS_SB(sb)->options.nfs == FAT_NFS_LIMITED)
>> + inode->i_ino = i_pos;
>> + else
>> + inode->i_ino = iunique(sb, MSDOS_ROOT_INO);
>> inode->i_version = 1;
>> err = fat_fill_inode(inode, de);
>> if (err) {
>
> I think we don't need this. Because FH and ino is not necessary to have
> relation.
>
> Can we re-introduce ->encode_fh() handler, and export i_pos again? With
> this, I think we can get i_pos correctly. Otherwise, ino may not contain
> all bits of i_pos.
I already tried to fix this issue using encode_fh without stable ino before.
But I reached conclusion that we should use stable inode number.
e.g. If we rebuild inode number using i_pos of fh, inode number is
changed by i_unique.
And It is not match with inode number of FH on NFS client. So estale
error will happen.
Thanks.
> --
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>
next prev parent reply other threads:[~2012-09-24 4:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 12:22 [PATCH v3 2/5] fat: allocate persistent inode numbers Namjae Jeon
2012-09-22 11:31 ` OGAWA Hirofumi
2012-09-24 4:11 ` Namjae Jeon [this message]
2012-09-24 4:39 ` OGAWA Hirofumi
2012-09-24 4:58 ` Namjae Jeon
2012-09-24 6:31 ` OGAWA Hirofumi
2012-09-24 6:36 ` OGAWA Hirofumi
2012-09-24 7:02 ` Namjae Jeon
2012-09-24 10:08 ` OGAWA Hirofumi
2012-09-24 10:29 ` Namjae Jeon
2012-09-24 10:57 ` OGAWA Hirofumi
2012-09-24 11:20 ` Namjae Jeon
2012-09-24 12:32 ` OGAWA Hirofumi
2012-09-24 14:35 ` Namjae Jeon
2012-09-24 14:57 ` J. Bruce Fields
2012-09-24 16:16 ` OGAWA Hirofumi
2012-09-24 16:22 ` J. Bruce Fields
2012-09-25 5:33 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKYAXd-6k7=RmrweR=wTOET50hy8Y7LokCSe1c2JtYd7pzPmsQ@mail.gmail.com' \
--to=linkinjeon@gmail.com \
--cc=a.sahrawat@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=ravi.n1@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).