From: Namjae Jeon <linkinjeon@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: hirofumi@mail.parknet.co.jp, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org,
Amit Sahrawat <amit.sahrawat83@gmail.com>
Subject: Re: [PATCH] fat: remove redundent call to fat_detach in vfat_unlink
Date: Mon, 3 Sep 2012 15:08:38 +0900 [thread overview]
Message-ID: <CAKYAXd-JApY3-4eBn5mDv_fB8JweHDUqdUX7y6ChTkuYbJNjVQ@mail.gmail.com> (raw)
In-Reply-To: <20120831172900.GC23464@ZenIV.linux.org.uk>
2012/9/1, Al Viro <viro@zeniv.linux.org.uk>:
> On Fri, Aug 31, 2012 at 12:48:07PM -0400, Namjae Jeon wrote:
>> As after file is removed fat_evict_inode will be called and fat_detach
>> will be called from that place. So, fat_detach can be removed from
>> vfat_unlink
>
> NAK. Please, realize that unlink and destruction of file are separate
> operations. ->evict_inode() may be called long after ->unlink(); moreover,
> during that time you might have another file created, getting the
> same directory entry our file used to have.
>
> This is Unix, damnit. You *can* open file, then unlink it and that file
> will keep existing (i.e. you can write to that descriptor, read, etc.)
> until it's closed.
>
Hi Al.
Sorry for noise. I understand what you said.
There was some confusing to me while checking fat's estale issue.:)
I will re-post patch-set about fat estale issue soon.(fix side-effect
informed by you and ogawa)
I am grateful that you review these patches also if you have time.
Thanks.
prev parent reply other threads:[~2012-09-03 6:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 16:48 [PATCH] fat: remove redundent call to fat_detach in vfat_unlink Namjae Jeon
2012-08-31 17:29 ` Al Viro
2012-09-03 6:08 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKYAXd-JApY3-4eBn5mDv_fB8JweHDUqdUX7y6ChTkuYbJNjVQ@mail.gmail.com \
--to=linkinjeon@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amit.sahrawat83@gmail.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).