From: Namjae Jeon <linkinjeon@gmail.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: akpm@linux-foundation.org, bfields@fieldses.org,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
Namjae Jeon <namjae.jeon@samsung.com>,
Ravishankar N <ravi.n1@samsung.com>,
Amit Sahrawat <a.sahrawat@samsung.com>
Subject: Re: [PATCH v2 4/5] fat: eliminate orphaned inode number allocation
Date: Thu, 6 Sep 2012 15:30:52 +0900 [thread overview]
Message-ID: <CAKYAXd8my3y9WXVwC0coYO=qTrSnGMoc+k14yx9t77tzJdax_g@mail.gmail.com> (raw)
In-Reply-To: <87r4qg374w.fsf@devron.myhome.or.jp>
2012/9/5 OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>:
> Namjae Jeon <linkinjeon@gmail.com> writes:
>
>> 2012/9/5, OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>:
>>> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
>>>
>>>> Namjae Jeon <linkinjeon@gmail.com> writes:
>>>>
>>>>> From: Namjae Jeon <namjae.jeon@samsung.com>
>>>>>
>>>>> Maintain a list of inode(i_pos) numbers of orphaned inodes (i.e the
>>>>> inodes that have been unlinked but still having open file
>>>>> descriptors).At file/directory creation time, skip using such i_pos
>>>>> values.Removal of the i_pos from the list is done during inode eviction.
>>>>
>>>> What happens if the directory (has busy entries) was completely removed?
>> Hi OGAWA.
>> There are 2 cases:
>> 1. The cluster can be used as a data cluster of a file - In which case
>> we can write
>> normally into it.
>> 2. The cluster can be allocated to a new directory. In this case, the busy i_pos
>> locations can not be used to create new entries until the correspnding
>> inodes are
>> evicted.
>
> In the (2) case, it has problem. Directory must not have de->name[0] == 0
> in middle of entires. "0" means the end of directory.
Good point! I will fix it on next version of patches.
Thanks.
> --
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2012-09-06 6:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 15:58 [PATCH v2 4/5] fat: eliminate orphaned inode number allocation Namjae Jeon
2012-09-04 17:00 ` OGAWA Hirofumi
2012-09-04 17:07 ` OGAWA Hirofumi
2012-09-04 18:38 ` J. Bruce Fields
2012-09-04 19:02 ` OGAWA Hirofumi
2012-09-04 19:25 ` J. Bruce Fields
2012-09-04 20:45 ` NeilBrown
2012-09-05 13:37 ` Namjae Jeon
2012-09-05 13:56 ` OGAWA Hirofumi
2012-09-06 6:30 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKYAXd8my3y9WXVwC0coYO=qTrSnGMoc+k14yx9t77tzJdax_g@mail.gmail.com' \
--to=linkinjeon@gmail.com \
--cc=a.sahrawat@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=ravi.n1@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).