From: Namjae Jeon <linkinjeon@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org,
Namjae Jeon <namjae.jeon@samsung.com>,
Ashish Sangwan <a.sangwan@samsung.com>,
Bonggil Bak <bgbak@samsung.com>
Subject: Re: [PATCH v2] udf: extent cache implementation for manipulating block map
Date: Tue, 4 Sep 2012 19:06:37 +0900 [thread overview]
Message-ID: <CAKYAXd9gEu5mAYa9a8GVPC9h8_QnFA=b2vSkWEcUJ2GAWKP8vA@mail.gmail.com> (raw)
In-Reply-To: <20120904095506.GA5673@quack.suse.cz>
2012/9/4 Jan Kara <jack@suse.cz>:
> On Tue 04-09-12 16:45:42, Namjae Jeon wrote:
>> 2012/9/3, Jan Kara <jack@suse.cz>:
>> >> +void udf_clear_extent_cache(struct udf_inode_info *iinfo)
>> >> +{
>> >> + if (iinfo->cached_extent.sanity) {
>> >> + brelse(iinfo->cached_extent.epos.bh);
>> >> + memset(&iinfo->cached_extent, 0, sizeof(struct udf_ext_cache));
>> >> + }
>> >> +}
>> >> +
>> > I think udf_clear_entent_cache() should take i_extent_cache_lock. Or if
>> > you are sure it's not needed, you need a good documentation why.
>> Documentation ? I am a little confusing.. It means udf.txt is in
>> Documentation/filesystem/ ?
>> or comment about clear extent function ?
> I meant in a comment before udf_clear_extent_cache() function...
Okay, I understood.
Thanks a lot.
>
> Honza
> --
> Jan Kara <jack@suse.cz>
> SUSE Labs, CR
prev parent reply other threads:[~2012-09-04 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 16:51 [PATCH v2] udf: extent cache implementation for manipulating block map Namjae Jeon
2012-09-03 12:45 ` Jan Kara
2012-09-04 7:45 ` Namjae Jeon
2012-09-04 9:55 ` Jan Kara
2012-09-04 10:06 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKYAXd9gEu5mAYa9a8GVPC9h8_QnFA=b2vSkWEcUJ2GAWKP8vA@mail.gmail.com' \
--to=linkinjeon@gmail.com \
--cc=a.sangwan@samsung.com \
--cc=bgbak@samsung.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).