From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64285C433F5 for ; Wed, 10 Nov 2021 02:28:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4646F61179 for ; Wed, 10 Nov 2021 02:28:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229917AbhKJCat (ORCPT ); Tue, 9 Nov 2021 21:30:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229717AbhKJCar (ORCPT ); Tue, 9 Nov 2021 21:30:47 -0500 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2024EC061764; Tue, 9 Nov 2021 18:28:01 -0800 (PST) Received: by mail-io1-xd2b.google.com with SMTP id f9so1028929ioo.11; Tue, 09 Nov 2021 18:28:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NZa7ro0mt+1m73OfXo7S1sh7QMO6OoAdAVHj6tyyP3w=; b=RwGT3awlgpV7L6eTUuK+fhfL8t4M2SvV96j1JF+T3BtTm0WgyYoxws36gSEjazdUx0 ooWxhkSKADc5pu1Z+APBY73BmzWMW92OvwmvQ9sdHM5PdJGdoBz8OLih73W+n159xsP2 F1U4CwQ1qMuhi86TruvllC0JEulr9Sn28uQEhk/XsNtTf9BgsG9rhVxgMeYx8yjkcqXn sl2LbIEhHfS2XKjo1sMHoV7XsYMnB2pEj4Xjlh4gvFbsCyl1ZqPzBj6qVbbw4EV4DOGk YQ4SWyErdWOOnHbsXgvuE6QTzkHZdVEqQ58qq6SaDrI+20EcSJH67EaDQNy0n7GlXEe4 MKIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NZa7ro0mt+1m73OfXo7S1sh7QMO6OoAdAVHj6tyyP3w=; b=QdV3FbmbWMShUtbIG3A9Cxjk7WrGDyhwFdiMJUH8hZlVS1I7ilhkJe7lzqj9lBAPWC nL02efs/FD2ED8We1uqTRxOe7nc9Wz1nXn8R4ei86Xpex8cO5ZWSOdM6SCTEviDzYigR T9hUezCSbdaiInvXarkqISxgGucwQ+PAAmf44bhf3+N43PBoPT29SJe8YBaNHbxcMBVY a01qsIKuv+2Fqlf+Y8uJtSu4N0+a9b1X2qfFMRT+W53aUAipzhAfNAw160zPqX2/3zAC du7M7ACbKWdLvmwONMKHiieKdr6JB34wRAc1hU1Tofbd53yYDYNkfp+rjzGWgpqymTvP 94FQ== X-Gm-Message-State: AOAM5320IhWReNs/MtVkrMWv544v5yCMy0M5T0/vuHxFn3BVdW73yA5/ 6FmfNyXxNJxG+oAvkz5i6FB0ms1bpiaRMMqrsRo= X-Google-Smtp-Source: ABdhPJz2OQAmvT8DPC+HdByniVeapr1YeGE2uk9XjMA0mDMCS0vKj6j44XdMVIWTqAolIW3RZSLLDd9BdIE5WyvnXqU= X-Received: by 2002:a02:cf3c:: with SMTP id s28mr9384203jar.140.1636511280320; Tue, 09 Nov 2021 18:28:00 -0800 (PST) MIME-Version: 1.0 References: <20210730041355.2810397-1-art@khadas.com> <20210730041355.2810397-4-art@khadas.com> <24363743-48fb-c01f-eb5d-0cd486d099f7@roeck-us.net> In-Reply-To: <24363743-48fb-c01f-eb5d-0cd486d099f7@roeck-us.net> From: Art Nikpal Date: Wed, 10 Nov 2021 10:27:48 +0800 Message-ID: Subject: Re: [PATCH v4 3/3] watchdog: meson_gxbb_wdt: remove stop_on_reboot To: Guenter Roeck Cc: Neil Armstrong , wim@linux-watchdog.org, Kevin Hilman , Jerome Brunet , Christian Hewitt , Martin Blumenstingl , linux-watchdog@vger.kernel.org, linux-arm-kernel , "open list:ARM/Amlogic Meson..." , LKML , Artem Lapkin , Nick Xie , Gouwa Wang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 9, 2021 at 11:30 PM Guenter Roeck wrote: > > On 11/8/21 11:59 PM, Art Nikpal wrote: > > hi Guenter Roeck > > why still not merged to upstream ? > > > > I had asked you to provide an updated description, without the "personal > opinion" part which does not belong into a commit log. The other two > patches wait for Wim to send them upstream. > ok i have send this patch with new description again > Guenter > > > > On Fri, Jul 30, 2021 at 12:14 PM Artem Lapkin wrote: > >> > >> Remove watchdog_stop_on_reboot() > >> > >> Meson platform still have some hardware drivers problems for some > >> configurations which can freeze device on shutdown/reboot stage and i > >> think better to have reboot warranty by default. > >> > >> I feel that it is important to keep the watchdog running during the > >> reboot sequence, in the event that an abnormal driver freezes the reboot > >> process. > >> > >> This is my personal opinion and I hope the driver authors will agree > >> with my proposal, or just ignore this commit if not. > >> > >> https://lore.kernel.org/linux-watchdog/20210729072308.1908904-1-art@khadas.com/T/#t > >> > >> Signed-off-by: Artem Lapkin > >> --- > >> drivers/watchdog/meson_gxbb_wdt.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c > >> index 945f5e65db57..d3c9e2f6e63b 100644 > >> --- a/drivers/watchdog/meson_gxbb_wdt.c > >> +++ b/drivers/watchdog/meson_gxbb_wdt.c > >> @@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) > >> > >> meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout); > >> > >> - watchdog_stop_on_reboot(&data->wdt_dev); > >> return devm_watchdog_register_device(dev, &data->wdt_dev); > >> } > >> > >> -- > >> 2.25.1 > >> >