From: Art Nikpal <email2tema@gmail.com>
To: 陈华才 <chenhuacai@loongson.cn>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Yue Wang <yue.wang@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Wilczynski <kw@linux.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Christian Hewitt <christianshewitt@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
PCI <linux-pci@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
linux-kernel@vger.kernel.org, Artem Lapkin <art@khadas.com>,
Nick Xie <nick@khadas.com>, Gouwa Wang <gouwa@khadas.com>,
chenhuacai@gmail.com
Subject: Re: Re: [PATCH 0/4] PCI: replace dublicated MRRS limit quirks
Date: Mon, 5 Jul 2021 16:35:19 +0800 [thread overview]
Message-ID: <CAKaHn9KxRrBsn4b9fSO1eDzM3XdV2GzfwVX+cGw9uS_eKg75dw@mail.gmail.com> (raw)
In-Reply-To: <67a9e1fa.81a9.17a64c8e7f7.Coremail.chenhuacai@loongson.cn>
> Does that means keystone and Loongson has the same MRRS problem? And what should I do now?
Look like yes ! and amlogic has the same problem.
I think somebody need to rewrite it all to one common quirk for this problem.
If no one has any objection, I can try to remake it again.
On Fri, Jul 2, 2021 at 9:15 AM 陈华才 <chenhuacai@loongson.cn> wrote:
>
> Hi, Bjorn,
>
> > -----原始邮件-----
> > 发件人: "Bjorn Helgaas" <helgaas@kernel.org>
> > 发送时间: 2021-07-01 23:46:34 (星期四)
> > 收件人: "Artem Lapkin" <email2tema@gmail.com>
> > 抄送: narmstrong@baylibre.com, yue.wang@Amlogic.com, khilman@baylibre.com, lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, jbrunet@baylibre.com, christianshewitt@gmail.com, martin.blumenstingl@googlemail.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, art@khadas.com, nick@khadas.com, gouwa@khadas.com, "Huacai Chen" <chenhuacai@loongson.cn>
> > 主题: Re: [PATCH 0/4] PCI: replace dublicated MRRS limit quirks
> >
> > [+cc Huacai]
> >
> > On Sat, Jun 19, 2021 at 02:39:48PM +0800, Artem Lapkin wrote:
> > > Replace dublicated MRRS limit quirks by mrrs_limit_quirk from core
> > > * drivers/pci/controller/dwc/pci-keystone.c
> > > * drivers/pci/controller/pci-loongson.c
> >
> > s/dublicated/duplicated/ (several occurrences)
> >
> > Capitalize subject lines.
> >
> > Use "git log --online" to learn conventions and follow them.
> >
> > Add "()" after function names.
> >
> > Capitalize acronyms appropriately (NVMe, MRRS, PCI, etc).
> >
> > End sentences with periods.
> >
> > A "move" patch must include both the removal and the addition and make
> > no changes to the code itself.
> >
> > Amlogic appears without explanation in 2/4. Must be separate patch to
> > address only that specific issue. Should reference published erratum
> > if possible. "Solves some issue" is not a compelling justification.
> >
> > The tree must be consistent and functionally the same or improved
> > after every patch.
> >
> > Add to pci_ids.h only if symbol used more than one place.
> >
> > See
> > https://lore.kernel.org/r/20210701074458.1809532-3-chenhuacai@loongson.cn,
> > which looks similar. Combine efforts if possible and cc Huacai so
> > you're both aware of overlapping work.
> >
> > More hints in case they're useful:
> > https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com/
> >
> > > Both ks_pcie_quirk loongson_mrrs_quirk was rewritten without any
> > > functionality changes by one mrrs_limit_quirk
> Does that means keystone and Loongson has the same MRRS problem? And what should I do now?
>
> Huacai
> > >
> > > Added DesignWare PCI controller which need same quirk for
> > > * drivers/pci/controller/dwc/pci-meson.c (PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3)
> > >
> > > This quirk can solve some issue for Khadas VIM3/VIM3L(Amlogic)
> > > with HDMI scrambled picture and nvme devices at intensive writing...
> > >
> > > come from:
> > > * https://lore.kernel.org/linux-pci/20210618063821.1383357-1-art@khadas.com/
> > >
> > > Artem Lapkin (4):
> > > PCI: move Keystone and Loongson device IDs to pci_ids
> > > PCI: core: quirks: add mrrs_limit_quirk
> > > PCI: keystone move mrrs quirk to core
> > > PCI: loongson move mrrs quirk to core
> > >
> > > --
> > > 2.25.1
> > >
>
>
> </chenhuacai@loongson.cn></email2tema@gmail.com></helgaas@kernel.org>
next prev parent reply other threads:[~2021-07-05 8:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 6:39 [PATCH 0/4] PCI: replace dublicated MRRS limit quirks Artem Lapkin
2021-06-19 6:39 ` [PATCH 1/4] PCI: move Keystone and Loongson device IDs to pci_ids Artem Lapkin
2021-06-19 6:39 ` [PATCH 2/4] PCI: core: quirks: add mrrs_limit_quirk Artem Lapkin
2021-07-01 17:07 ` Rob Herring
2021-06-19 6:39 ` [PATCH 3/4] PCI: keystone move mrrs quirk to core Artem Lapkin
2021-06-19 6:39 ` [PATCH 4/4] PCI: loongson " Artem Lapkin
2021-07-01 15:46 ` [PATCH 0/4] PCI: replace dublicated MRRS limit quirks Bjorn Helgaas
2021-07-02 1:15 ` 陈华才
2021-07-05 8:35 ` Art Nikpal [this message]
2021-07-05 22:34 ` Krzysztof Wilczynski
2021-07-06 1:36 ` Huacai Chen
2021-07-06 6:06 ` Art Nikpal
2021-07-06 9:54 ` Neil Armstrong
2021-07-07 15:54 ` Bjorn Helgaas
2021-07-07 16:43 ` Neil Armstrong
2021-07-07 16:57 ` Bjorn Helgaas
2021-07-07 17:21 ` Bjorn Helgaas
2021-07-12 9:08 ` Art Nikpal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKaHn9KxRrBsn4b9fSO1eDzM3XdV2GzfwVX+cGw9uS_eKg75dw@mail.gmail.com \
--to=email2tema@gmail.com \
--cc=art@khadas.com \
--cc=chenhuacai@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=christianshewitt@gmail.com \
--cc=gouwa@khadas.com \
--cc=helgaas@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kw@linux.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=nick@khadas.com \
--cc=robh@kernel.org \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).