From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA7FC433E0 for ; Tue, 23 Feb 2021 18:15:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EA3464EC1 for ; Tue, 23 Feb 2021 18:15:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233848AbhBWSPL (ORCPT ); Tue, 23 Feb 2021 13:15:11 -0500 Received: from mail-il1-f169.google.com ([209.85.166.169]:46391 "EHLO mail-il1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233817AbhBWSO4 (ORCPT ); Tue, 23 Feb 2021 13:14:56 -0500 Received: by mail-il1-f169.google.com with SMTP id i18so2171004ilq.13 for ; Tue, 23 Feb 2021 10:14:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NBD19TtNuqKmtZTJ8bFpz+xLfryH6M8evU2W8orJimw=; b=AxpqRPgiZpLeJpudauMu58fFjZbDKykbw4VK9oUSdygJSoYAxFwMiZ1DcSuQEnj/e4 2PqKN0oL1pVnuuLLrlkZLZOqqM0FvWc7LYWM8yap3YlEiRq5S1d9ZoBd23GN6dNNAhCF J+tqggI4qM48JrwXq4rKDpfJk6d7CFks5dy+PzTNEZ8g3Xrf6ZqMqRvgzxCcpdLnJg/y Vi2gASwWjJjxVfVeN9pzYU1XucMx5Z3aqPQ4gVi//g5472DlOU0XjYdydQsnnxsQUZ4p 6tD25svBVl4Mnybty7/a4v4ZRi3NgFzqmQUFeIfrSskaI3XQFmCl5uokRFQA2wa1YP89 Yx7g== X-Gm-Message-State: AOAM531CWBsjNdgCxNtEG5TwXG3LB9h4povy4vsSfzzGmSEAR+lgLtj7 Vf0zWoS2ACqlfWqv8OSUZcU7piZRr3X6DhgoQUQ= X-Google-Smtp-Source: ABdhPJxx/TZSCisENcO5Uxe7yUnXfib+nh/4u/AobThe/PiT92Zy413z/FV3yJKDnruuyr4rRyoAcPmxOiybsL3TF6Q= X-Received: by 2002:a05:6e02:1848:: with SMTP id b8mr20333140ilv.210.1614104050299; Tue, 23 Feb 2021 10:14:10 -0800 (PST) MIME-Version: 1.0 References: <20210119015415.2511028-1-lyude@redhat.com> <20210119015415.2511028-2-lyude@redhat.com> In-Reply-To: From: Ilia Mirkin Date: Tue, 23 Feb 2021 13:13:59 -0500 Message-ID: Subject: Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace To: Alex Riesen Cc: Lyude Paul , Pankaj Bharadiya , David Airlie , nouveau , James Jones , LKML , dri-devel , Jeremy Cline , Ben Skeggs , Dave Airlie Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 23, 2021 at 11:23 AM Alex Riesen wrote: > > Alex Riesen, Tue, Feb 23, 2021 16:51:26 +0100: > > Ilia Mirkin, Tue, Feb 23, 2021 16:46:52 +0100: > > > I'd recommend using xf86-video-nouveau in any case, but some distros > > > > I would like try this out. Do you know how to force the xorg server to > > choose this driver instead of modesetting? > > Found that myself (a Device section with Driver set to "nouveau"): > > $ xrandr --listproviders > Providers: number : 1 > Provider 0: id: 0x68 cap: 0x7, Source Output, Sink Output, Source Offload crtcs: 4 outputs: 5 associated providers: 0 name:nouveau > > And yes, the cursor looks good in v5.11 even without reverting the commit. FWIW it's not immediately apparent to me what grave error modesetting is committing in setting the cursor. The logic looks perfectly reasonable. It's not trying to be fancy with rendering the cursor/etc. The one thing is that it's using drmModeSetCursor2 which sets the hotspot at the same time. But internally inside nouveau I think it should work out to the same thing. Perhaps setting the hotspot, or something in that path, doesn't quite work for 256x256? [Again, no clue what that might be.] It might also be worthwhile just testing if the 256x256 cursor works quite the way one would want. If you're interested, grab libdrm, there's a test called 'modetest', which has an option to enable a moving cursor (-c iirc). It's hard-coded to 64x64, so you'll have to modify it there too (and probably change the pattern from plain gray to any one of the other ones). Cheers, -ilia