* linux-next: build failure after merge of the input-current tree
@ 2018-09-18 22:25 Stephen Rothwell
2018-09-18 22:32 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2018-09-18 22:25 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Daniel Drake,
Rafael J. Wysocki
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
Hi Dmitry,
After merging the input-current tree, today's linux-next build (x86_64
allmodconfig) failed like this:
ERROR: "mem_sleep_current" [drivers/input/serio/i8042.ko] undefined!
Caused by commit
1685830e59d4 ("Input: i8042 - enable keyboard wakeups by default when s2idle is used")
I have used the version of input-current from next-20180918 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: linux-next: build failure after merge of the input-current tree
2018-09-18 22:25 linux-next: build failure after merge of the input-current tree Stephen Rothwell
@ 2018-09-18 22:32 ` Dmitry Torokhov
2018-09-20 8:02 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2018-09-18 22:32 UTC (permalink / raw)
To: Stephen Rothwell, Daniel Drake, Rafael J. Wysocki; +Cc: linux-next, lkml
On Tue, Sep 18, 2018 at 3:25 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Dmitry,
>
> After merging the input-current tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "mem_sleep_current" [drivers/input/serio/i8042.ko] undefined!
>
> Caused by commit
>
> 1685830e59d4 ("Input: i8042 - enable keyboard wakeups by default when s2idle is used")
>
> I have used the version of input-current from next-20180918 for today.
Ugh, sorry, I dropped that patch from my tree for now.
Daniel, Rafael, I guess we can't make pm_suspend_via_s2idle() static
inline, but instead move it into kernel/power/suspend.c and make it
EXPORT_SYMBOL().
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: linux-next: build failure after merge of the input-current tree
2018-09-18 22:32 ` Dmitry Torokhov
@ 2018-09-20 8:02 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2018-09-20 8:02 UTC (permalink / raw)
To: Dmitry Torokhov, Daniel Drake
Cc: Stephen Rothwell, Rafael J. Wysocki, linux-next, lkml
On Wednesday, September 19, 2018 12:32:03 AM CEST Dmitry Torokhov wrote:
> On Tue, Sep 18, 2018 at 3:25 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi Dmitry,
> >
> > After merging the input-current tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > ERROR: "mem_sleep_current" [drivers/input/serio/i8042.ko] undefined!
> >
> > Caused by commit
> >
> > 1685830e59d4 ("Input: i8042 - enable keyboard wakeups by default when s2idle is used")
> >
> > I have used the version of input-current from next-20180918 for today.
>
> Ugh, sorry, I dropped that patch from my tree for now.
>
> Daniel, Rafael, I guess we can't make pm_suspend_via_s2idle() static
> inline, but instead move it into kernel/power/suspend.c and make it
> EXPORT_SYMBOL().
Either that, or mem_sleep_current would need to be exported. Sorry for
missing that.
Daniel, I prefer the wrapper to be a regular function in suspend.c.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 5+ messages in thread
* linux-next: build failure after merge of the input-current tree
@ 2019-05-23 22:24 Stephen Rothwell
2019-05-23 22:52 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2019-05-23 22:24 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Fabien Parent
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
Hi all,
After merging the input-current tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/input/keyboard/mtk-pmic-keys.c:21:10: fatal error: linux/mfd/mt6392/registers.h: No such file or directory
#include <linux/mfd/mt6392/registers.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Caused by commit
78094276ca6a ("Input: mtk-pmic-keys - add support for MT6392")
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: linux-next: build failure after merge of the input-current tree
2019-05-23 22:24 Stephen Rothwell
@ 2019-05-23 22:52 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2019-05-23 22:52 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Fabien Parent
On Fri, May 24, 2019 at 08:24:46AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the input-current tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/input/keyboard/mtk-pmic-keys.c:21:10: fatal error: linux/mfd/mt6392/registers.h: No such file or directory
> #include <linux/mfd/mt6392/registers.h>
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Caused by commit
>
> 78094276ca6a ("Input: mtk-pmic-keys - add support for MT6392")
>
> I have reverted that commit for today.
Sorry about that, I dropped the patch from the tree.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-23 22:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-18 22:25 linux-next: build failure after merge of the input-current tree Stephen Rothwell
2018-09-18 22:32 ` Dmitry Torokhov
2018-09-20 8:02 ` Rafael J. Wysocki
2019-05-23 22:24 Stephen Rothwell
2019-05-23 22:52 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).