From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751976AbdBTVvD (ORCPT ); Mon, 20 Feb 2017 16:51:03 -0500 Received: from mail-ua0-f195.google.com ([209.85.217.195]:34063 "EHLO mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751926AbdBTVuy (ORCPT ); Mon, 20 Feb 2017 16:50:54 -0500 MIME-Version: 1.0 In-Reply-To: References: <201702202042.15878@pali> <201702202208.50498@pali> From: Dmitry Torokhov Date: Mon, 20 Feb 2017 13:50:51 -0800 Message-ID: Subject: Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation To: "H. Nikolaus Schaller" Cc: =?UTF-8?Q?Pali_Roh=C3=A1r?= , Sebastian Reichel , Mark Rutland , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Russell King , Arnd Bergmann , Michael Welling , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Javier Martinez Canillas , Igor Grinberg , "Andrew F. Davis" , Mark Brown , Jonathan Cameron , Rob Herring , Alexander Stein , Eric Engestrom , Hans de Goede , Benjamin Tissoires , Petr Cvek , Mauro Carvalho Chehab , Hans Verkuil , Nick Dyer , Siebren Vroegindeweij , Michel Verlaan , "linux-input@vger.kernel.org" , "devicetree@vger.kernel.org" , lkml , Linux OMAP Mailing List , Discussions about the Letux Kernel , linux-iio@vger.kernel.org, kernel@pyra-handheld.com, Aaro Koskinen , Pavel Machek , Andrey Gelman , Haibo Chen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1KLpJV3002412 On Mon, Feb 20, 2017 at 1:27 PM, H. Nikolaus Schaller wrote: > >> Am 20.02.2017 um 22:08 schrieb Pali Rohár : >> >> On Monday 20 February 2017 20:42:15 Pali Rohár wrote: >>> Hi Nikolaus! >>> >>> On Monday 20 February 2017 17:50:04 H. Nikolaus Schaller wrote: >>>> Hi Dmitry, >>>> >>>>> Input driver may set resolution for given axis in units per mm >>>>> (or units per radian for rotational axis ABS_RX, ABS_RY, >>>>> ABS_RZ), and if you check the binding, you can use >>>>> "touchscreen-x-mm" and "touchscreen-y-mm" to specify the size of >>>>> entire touch surface and set resolution from it so that >>>>> userspace can calculate the proper scaling factor. >>>> >>>> How is this information exposed by the kernel to user-space? By >>>> scanning the DT file or tree? >>> >>> Set input_abs_set_res() from kernel. And in userspace call EVIOCGABS >>> ioctl() on input device. Look at struct input_absinfo, you should >>> have all needed information here. This is generic input interface, >>> no DT is needed. >> >> Looking at kernel code... via EVIOCSABS ioctl() you can even set >> resolution from userspace for specified input device. >> >> So this could be potentially used for calibrating input device from >> userspace? (In case DT data will not fully match current HW) >> >>> I hope that XServer is already using it for evdev devices... >>> >>> For whole implementation look at evtest program. That should be good >>> starting point for your userspace implementation. >>> >>> While I'm watching this discussion... in my opinion kernel should >>> just invert input axes (when needed) > > It is questionable why it should do that at all then. Because the task of the kernel is to provide unified view of the hardware. Axis swapping and inversion is needed to that "up" is always "up" and "right" is always "right". Thanks. -- Dmitry