From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932546AbcKMHNe (ORCPT ); Sun, 13 Nov 2016 02:13:34 -0500 Received: from mail-vk0-f65.google.com ([209.85.213.65]:34314 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbcKMHNd (ORCPT ); Sun, 13 Nov 2016 02:13:33 -0500 MIME-Version: 1.0 In-Reply-To: <201611122039.33245@pali> References: <20161112191545.GA19531@dtor-ws> <201611122039.33245@pali> From: Dmitry Torokhov Date: Sat, 12 Nov 2016 23:13:31 -0800 Message-ID: Subject: Re: [PATCH] Input: psmouse - disable automatic probing of BYD touchpads To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: "linux-input@vger.kernel.org" , Hans de Goede , Chris Diamand , Frederick Billings , Michael Shell , Eric Wong , Ondrej Zary , Christophe TORDEUX , Richard Pospesel , lkml Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAD7De4Q004402 On Sat, Nov 12, 2016 at 11:39 AM, Pali Rohár wrote: > On Saturday 12 November 2016 20:15:45 Dmitry Torokhov wrote: >> BYD automatic protocol detection is extremely unreliable and is often >> triggers false positives on regular mice, Sentelic touchpads, and >> other devices. BYD has several documents that have recommended >> detection sequence, but they conflict with each other and, as far as >> I can see, still would not produce unique enough output to reliably >> differentiate BYD from other PS/2 devices. >> >> OEMs sourcing BYD devices also do not do us any favors by not >> supplying any reasonable DMI data and instead leaving turds like "To >> Be Filled By O.E.M." in place of vendor data, or "System Serial >> Number" as serial number. > ... >> echo -n "byd" > /sys/bus/serio/devices/serio1/drvctl > > I agree, if we cannot detect BYD devices correctly without breaking > other non-BYD devices then detection must be done by user... > > So you can add my Reviewed-by: Pali Rohár to this patch. > > Anyway, BYD show Linux as supported OS for their devices. It is really > rude from BYD that they show Linux as supported OS, but Linux driver is > reverse-engineered by community and they do not want to cooperate and at > least provide some useful documentation for detection... I am not even sure they have a good way of detecting their devices. The Windows model is that vendor supplies OEM with their driver and it just works (I do not think these devices have external PS/2 ports so there is no concern with mis-detection). Thanks. -- Dmitry