From: Dmitry Torokhov <dmitry.torokhov@gmail.com> To: Marek Szyprowski <m.szyprowski@samsung.com> Cc: Ravi Chandra Sadineni <ravisadineni@chromium.org>, Ravi Chandra Sadineni <ravisadineni@google.com>, Todd Broch <tbroch@google.com>, lkml <linux-kernel@vger.kernel.org>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event. Date: Sun, 5 Aug 2018 23:16:54 -0700 [thread overview] Message-ID: <CAKdAkRSvLq-L3FrODUqxXqDs2FymM9k5dZRxnOpc44rFiHaWAQ@mail.gmail.com> (raw) In-Reply-To: <20180806052949eucas1p2483800c02730febd03d4a661a25fa405~INH40XvCx2719627196eucas1p2X@eucas1p2.samsung.com> On Sun, Aug 5, 2018 at 10:29 PM Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > Hi Ravi, > > On 2018-08-03 18:53, Ravi Chandra Sadineni wrote: > > Understood. I am trying to reproduce this issue locally. Wanted to > > know the version of the kernel so I can give a try. Marek, can you > > please confirm the kernel version. > > > > Yes, sorry for the missing context, I was in hurry writing the report and > I wanted to send it before leaving the office. I'm testing mainline on Snow > with exynos_defconfig. > > Suspend/resume is partially broken already with mainline, but if you disable > CPUfreq support, it works fine on Linux v4.17. > > I've posted CPUfreq related fixes here if you are interested: > https://patchwork.kernel.org/patch/10554607/ > https://patchwork.kernel.org/patch/10554603/ > > The issue with cros_ec_keyb patch appears first on Linux v4.18-rc1, which is > the first release with that patch. Marek, this patch should only be in -next, I do not believe I sent it to Linus just yet. If mainline is broken for you it can't be caused by this patch. > Linux -next from 20180803, which has a few > more patches for cros_ec_keyb suffers from the same issue. Just to confirm, if you revert only this patch from -next you get suspend/resume back? Thanks. -- Dmitry
next prev parent reply other threads:[~2018-08-06 6:17 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-05 22:44 Ravi Chandra Sadineni 2018-06-12 23:32 ` Dmitry Torokhov [not found] ` <CGME20180803072628eucas1p26abe0cb121b974401759502f8807bb96@eucas1p2.samsung.com> 2018-08-03 7:26 ` Marek Szyprowski [not found] ` <CAEZbON7qLheHFuU6zwArCz=CG03JvnFjcehBGjE4RqROYrMLhQ@mail.gmail.com> 2018-08-03 16:07 ` Dmitry Torokhov [not found] ` <CAEZbON4O0X8Fo6eAbmPOSiB1_Tw7x+Ox3ROoGfZQn72uQGQLkg@mail.gmail.com> 2018-08-06 5:29 ` Marek Szyprowski 2018-08-06 6:16 ` Dmitry Torokhov [this message] 2018-08-06 7:15 ` Marek Szyprowski 2018-08-06 23:05 ` Ravi Chandra Sadineni 2018-08-07 21:59 ` Ravi Chandra Sadineni 2018-08-08 5:03 ` Marek Szyprowski [not found] ` <85a59afc-9dc0-b9fb-7e8f-32731337884c@samsung.com> 2018-08-10 8:23 ` Marek Szyprowski 2018-08-17 21:21 ` RaviChandra Sadineni 2018-08-20 8:52 ` Marek Szyprowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKdAkRSvLq-L3FrODUqxXqDs2FymM9k5dZRxnOpc44rFiHaWAQ@mail.gmail.com \ --to=dmitry.torokhov@gmail.com \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=ravisadineni@chromium.org \ --cc=ravisadineni@google.com \ --cc=tbroch@google.com \ --subject='Re: [PATCH] Input: cros_ec_keyb: Remove check before calling pm_wakeup_event.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).