From: Jason Andryuk <jandryuk@gmail.com>
To: Simon Gaiser <simon@invisiblethingslab.com>
Cc: netdev@vger.kernel.org, xen-devel@lists.xenproject.org,
Eduardo Otubo <otubo@redhat.com>, Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen-netfront: Fix hang on device removal
Date: Thu, 19 Apr 2018 14:14:43 -0400 [thread overview]
Message-ID: <CAKf6xpuusCJ0DMJ_G3hG5pd9vd8rUBH=VPa4TCvaoptGto-=Zw@mail.gmail.com> (raw)
In-Reply-To: <1b07e839-5633-3b1e-1997-b86a891b2962@invisiblethingslab.com>
On Thu, Apr 19, 2018 at 2:10 PM, Simon Gaiser
<simon@invisiblethingslab.com> wrote:
> Jason Andryuk:
>> A toolstack may delete the vif frontend and backend xenstore entries
>> while xen-netfront is in the removal code path. In that case, the
>> checks for xenbus_read_driver_state would return XenbusStateUnknown, and
>> xennet_remove would hang indefinitely. This hang prevents system
>> shutdown.
>>
>> xennet_remove must be able to handle XenbusStateUnknown, and
>> netback_changed must also wake up the wake_queue for that state as well.
>>
>> Fixes: 5b5971df3bc2 ("xen-netfront: remove warning when unloading module")
>
> I think this should go into stable since AFAIK the hanging network
> device can only be fixed by rebooting the guest. AFAICS this affects all
> 4.* branches since 5b5971df3bc2 got backported to them.
>
> Upstream commit c2d2e6738a209f0f9dffa2dc8e7292fc45360d61.
Simon,
Yes, I agree. I actually submitted the request to stable earlier
today, so hopefully it gets added soon.
Have you experienced this hang?
Regards,
Jason
next prev parent reply other threads:[~2018-04-19 18:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 12:23 [PATCH] xen-netfront: Fix hang on device removal Jason Andryuk
2018-02-28 15:21 ` [Xen-devel] " Boris Ostrovsky
2018-02-28 19:21 ` Juergen Gross
2018-04-19 18:10 ` [Xen-devel] " Simon Gaiser
2018-04-19 18:14 ` Jason Andryuk [this message]
2018-04-19 20:09 ` Simon Gaiser
2018-04-20 12:41 ` Jason Andryuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKf6xpuusCJ0DMJ_G3hG5pd9vd8rUBH=VPa4TCvaoptGto-=Zw@mail.gmail.com' \
--to=jandryuk@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=otubo@redhat.com \
--cc=simon@invisiblethingslab.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).