From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751165AbcGNIBh (ORCPT ); Thu, 14 Jul 2016 04:01:37 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:33894 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbcGNIBb convert rfc822-to-8bit (ORCPT ); Thu, 14 Jul 2016 04:01:31 -0400 MIME-Version: 1.0 In-Reply-To: References: <1468427945-11600-1-git-send-email-kristian.evensen@gmail.com> <87k2gpnpo5.fsf@miraculix.mork.no> From: Kristian Evensen Date: Thu, 14 Jul 2016 10:01:28 +0200 Message-ID: Subject: Re: [PATCH] rndis_host: Set random MAC for ZTE MF910 To: =?UTF-8?Q?Bj=C3=B8rn_Mork?= Cc: linux-usb@vger.kernel.org, Network Development , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2016 at 9:54 AM, Kristian Evensen wrote: > Hi Bjørn, > > On Thu, Jul 14, 2016 at 12:23 AM, Bjørn Mork wrote: >> >> Or how about the more generic?: >> >> if (bp[0] & 0x02) >> eth_hw_addr_random(net); >> else >> ether_addr_copy(net->dev_addr, bp); >> >> That would catch similar screwups from other vendors too. > > Great idea, thanks. After submitting the patch I found some other > devices with a similar bug, and there are probably even more out > there. I will update patch and resubmit. Oh, and I forgot to say, please ignore this patch. I will change the title and description to better describe the functionality. -Kristian