From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752425AbcGRO1p (ORCPT ); Mon, 18 Jul 2016 10:27:45 -0400 Received: from mail-lf0-f50.google.com ([209.85.215.50]:33417 "EHLO mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbcGRO1k (ORCPT ); Mon, 18 Jul 2016 10:27:40 -0400 MIME-Version: 1.0 In-Reply-To: <1468851242.2280.14.camel@suse.com> References: <1468844691-8222-1-git-send-email-kristian.evensen@gmail.com> <1468846886.2280.6.camel@suse.com> <1468849802.2280.11.camel@suse.com> <1468851242.2280.14.camel@suse.com> From: Kristian Evensen Date: Mon, 18 Jul 2016 16:27:36 +0200 Message-ID: Subject: Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling To: Oliver Neukum Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Network Development Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2016 at 4:14 PM, Oliver Neukum wrote: >> Ok, sounds good. So far, I have only seen the random MAC issue with >> the three previously mentioned devices, but who knows how many else is >> out there with the same error ... I don't think it should be in the >> core ethernet code, at least not yet, but I agree it would make sense >> to move it to for example usbnet_core(). If you agree, I can prepare a >> patch for it. > > I don't see how it would be specific for a subsystem. If the patch > is correct, it belongs into the networking core. To me it sounds a bit intrusive to change the networking core for something that has so far only been seen with devices belonging to one subsystem, but I will do it if required. I guess David M. will have an opinion on if we should add this fix on a per-driver basis, in usbnet or in the networking core? If we go for the latter, what would be correct place for this piece of code, register_netdevice()? -Kristian