From: Vincent Guittot <vincent.guittot@linaro.org>
To: Tao Zhou <tao.zhou@linux.dev>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: [PATCH V1 RESEND]: sched/fair: Revise comment about lb decision matrix
Date: Fri, 15 Apr 2022 10:32:09 +0200 [thread overview]
Message-ID: <CAKfTPtAbxAerbV-LBcpm_qHAphhD3uU47k0hu=DDX3k6LS-Aow@mail.gmail.com> (raw)
In-Reply-To: <20220415022246.14902-1-tao.zhou@linux.dev>
On Fri, 15 Apr 2022 at 04:22, Tao Zhou <tao.zhou@linux.dev> wrote:
>
> If busiest group type is group_misfit_task, the local
> group type must be group_has_spare according to below
> code in update_sd_pick_busiest():
>
> if (sgs->group_type == group_misfit_task &&
> (!capacity_greater(capacity_of(env->dst_cpu), sg->sgc->max_capacity) ||
> sds->local_stat.group_type != group_has_spare))
> return false;
>
> group type imbalanced and overloaded and fully_busy are filtered in here.
> misfit and asym are filtered before in update_sg_lb_stats().
The behavior has changed with
cad68e552e77 ("sched/fair: Consider misfit tasks when load-balancing")
But we haven't updated the matrix
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> So, change the decision matrix to:
>
> busiest \ local has_spare fully_busy misfit asym imbalanced overloaded
> has_spare nr_idle balanced N/A N/A balanced balanced
> fully_busy nr_idle nr_idle N/A N/A balanced balanced
> misfit_task force N/A N/A N/A *N/A* *N/A*
> asym_packing force force N/A N/A force force
> imbalanced force force N/A N/A force force
> overloaded force force N/A N/A force avg_load
>
> Fixes: 0b0695f2b34a ("sched/fair: Rework load_balance()")
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Signed-off-by: Tao Zhou <tao.zhou@linux.dev>
> ---
>
> v1 changelog:
> (1) Send to MAINTAINERS/REVIEWS get from `./scripts/get_maintainer.pl`
> suggested by Dietmar Eggemann.
> (2) Based on v5.18-rc2
>
>
> kernel/sched/fair.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index d4bd299d67ab..b8c67e7c8cf3 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -9495,7 +9495,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
> * busiest \ local has_spare fully_busy misfit asym imbalanced overloaded
> * has_spare nr_idle balanced N/A N/A balanced balanced
> * fully_busy nr_idle nr_idle N/A N/A balanced balanced
> - * misfit_task force N/A N/A N/A force force
> + * misfit_task force N/A N/A N/A N/A N/A
> * asym_packing force force N/A N/A force force
> * imbalanced force force N/A N/A force force
> * overloaded force force N/A N/A force avg_load
> --
> 2.35.2
>
next prev parent reply other threads:[~2022-04-15 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 2:22 [PATCH V1 RESEND]: sched/fair: Revise comment about lb decision matrix Tao Zhou
2022-04-15 8:32 ` Vincent Guittot [this message]
2022-04-15 10:03 ` Tao Zhou
2022-04-15 11:33 ` Peter Zijlstra
2022-04-15 9:55 Tao Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKfTPtAbxAerbV-LBcpm_qHAphhD3uU47k0hu=DDX3k6LS-Aow@mail.gmail.com' \
--to=vincent.guittot@linaro.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tao.zhou@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).