From: Vincent Guittot <vincent.guittot@linaro.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>
Subject: Re: [PATCH RESEND] sched: fix kernel-doc warning in attach_entity_load_avg()
Date: Mon, 10 Feb 2020 08:41:28 +0100 [thread overview]
Message-ID: <CAKfTPtAmG7WnZCZLKpK2SLG24W-Azr7P2E=41kz=1R9CJLwkvg@mail.gmail.com> (raw)
In-Reply-To: <cbe964e4-6879-fd08-41c9-ef1917414af4@infradead.org>
On Mon, 10 Feb 2020 at 04:29, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kernel-doc warning in kernel/sched/fair.c, caused by a recent
> function parameter removal:
>
> ../kernel/sched/fair.c:3526: warning: Excess function parameter 'flags' description in 'attach_entity_load_avg'
>
> Fixes: a4f9a0e51bbf ("sched/fair: Remove redundant call to cpufreq_update_util()")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Vincent Guittot <vincent.guittot@linaro.org> (SCHED_NORMAL)
> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com> (SCHED_NORMAL)
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
>
> ---
> kernel/sched/fair.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- lnx-56-rc1.orig/kernel/sched/fair.c
> +++ lnx-56-rc1/kernel/sched/fair.c
> @@ -3516,7 +3516,6 @@ update_cfs_rq_load_avg(u64 now, struct c
> * attach_entity_load_avg - attach this entity to its cfs_rq load avg
> * @cfs_rq: cfs_rq to attach to
> * @se: sched_entity to attach
> - * @flags: migration hints
> *
> * Must call update_cfs_rq_load_avg() before this, since we rely on
> * cfs_rq->avg.last_update_time being current.
>
>
next prev parent reply other threads:[~2020-02-10 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 3:29 [PATCH RESEND] sched: fix kernel-doc warning in attach_entity_load_avg() Randy Dunlap
2020-02-10 7:41 ` Vincent Guittot [this message]
2020-02-11 12:47 ` [tip: sched/urgent] sched/fair: Fix " tip-bot2 for Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKfTPtAmG7WnZCZLKpK2SLG24W-Azr7P2E=41kz=1R9CJLwkvg@mail.gmail.com' \
--to=vincent.guittot@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).