From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942102AbcJ0N50 (ORCPT ); Thu, 27 Oct 2016 09:57:26 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:36100 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934502AbcJ0N5W (ORCPT ); Thu, 27 Oct 2016 09:57:22 -0400 MIME-Version: 1.0 In-Reply-To: <1472094041-5357-2-git-send-email-guodong.xu@linaro.org> References: <1472094041-5357-1-git-send-email-guodong.xu@linaro.org> <1472094041-5357-2-git-send-email-guodong.xu@linaro.org> From: Vincent Guittot Date: Thu, 27 Oct 2016 15:56:59 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes To: Guodong Xu Cc: xuwei5@hisilicon.com, Rob Herring , rob.herring@linaro.org, Mark Rutland , Catalin Marinas , Will Deacon , "devicetree@vger.kernel.org" , xinliang.liu@linaro.org, linux-kernel , jh80.chung@samsung.com, John Stultz , Fathi Boudra , LAK Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, My hikey board failed to detect and mount sdcard with v4.9-rc1 and i have bisected the issue to this patch. Once reverted, the sdcard is detected again. Regards, Vincent On 25 August 2016 at 05:00, Guodong Xu wrote: > Add resets property into dwmmc_0, dwmmc_1 and dwmmc_2 for hi6220 > > Code and documentation to this property were confirmed by maintainers. > See: > [1] https://patchwork.kernel.org/patch/9276607/ > [2] https://patchwork.kernel.org/patch/8487151/ > [3] https://lkml.org/lkml/2016/8/12/91 > > cc: Jaehoon Chung > cc: Rob Herring > Signed-off-by: Guodong Xu > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index d0b887a..63608e9 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -771,6 +771,7 @@ > interrupts = <0x0 0x48 0x4>; > clocks = <&sys_ctrl 2>, <&sys_ctrl 1>; > clock-names = "ciu", "biu"; > + resets = <&sys_ctrl PERIPH_RSTDIS0_MMC0>; > bus-width = <0x8>; > vmmc-supply = <&ldo19>; > pinctrl-names = "default"; > @@ -790,6 +791,7 @@ > #size-cells = <0x0>; > clocks = <&sys_ctrl 4>, <&sys_ctrl 3>; > clock-names = "ciu", "biu"; > + resets = <&sys_ctrl PERIPH_RSTDIS0_MMC1>; > vqmmc-supply = <&ldo7>; > vmmc-supply = <&ldo10>; > bus-width = <0x4>; > @@ -807,6 +809,7 @@ > interrupts = <0x0 0x4a 0x4>; > clocks = <&sys_ctrl HI6220_MMC2_CIUCLK>, <&sys_ctrl HI6220_MMC2_CLK>; > clock-names = "ciu", "biu"; > + resets = <&sys_ctrl PERIPH_RSTDIS0_MMC2>; > bus-width = <0x4>; > broken-cd; > pinctrl-names = "default", "idle"; > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel