From: Vincent Guittot <vincent.guittot@linaro.org>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Zhang Rui <rui.zhang@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Amit Kachhap <amit.kachhap@gmail.com>,
viresh kumar <viresh.kumar@linaro.org>,
Javi Merino <javi.merino@kernel.org>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
Quentin Perret <quentin.perret@arm.com>,
Ionela Voinescu <ionela.voinescu@arm.com>
Subject: Re: [RFC PATCH 5/7] sched/fair: Enable CFS periodic tick to update thermal pressure
Date: Tue, 4 Dec 2018 16:43:58 +0100 [thread overview]
Message-ID: <CAKfTPtB18Fh3neT7d6m0fgthE6Zo0am4i9WQ9OriD3FCuZgrRw@mail.gmail.com> (raw)
In-Reply-To: <1539102302-9057-6-git-send-email-thara.gopinath@linaro.org>
Hi Thara,
On Tue, 9 Oct 2018 at 18:25, Thara Gopinath <thara.gopinath@linaro.org> wrote:
>
> Introduce support in CFS periodic tick to trigger the process of
> computing average thermal pressure for a cpu.
>
> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
> ---
> kernel/sched/fair.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index b39fb59..7deb1d0 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -21,6 +21,7 @@
> * Copyright (C) 2007 Red Hat, Inc., Peter Zijlstra
> */
> #include "sched.h"
> +#include "thermal.h"
>
> #include <trace/events/sched.h>
>
> @@ -9557,6 +9558,8 @@ static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued)
>
> if (static_branch_unlikely(&sched_numa_balancing))
> task_tick_numa(rq, curr);
> +
> + update_periodic_maxcap(rq);
You have to call update_periodic_maxcap() in update_blocked_averages() too
Otherwise, the thermal pressure will not always be updated correctly
for tickless system
> }
>
> /*
> --
> 2.1.4
>
next prev parent reply other threads:[~2018-12-04 15:44 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181009162509epcas1p4fdd2e23039caa24586a4a52c6d2e7336@epcas1p4.samsung.com>
2018-10-09 16:24 ` [RFC PATCH 0/7] Introduce thermal pressure Thara Gopinath
2018-10-09 16:24 ` [RFC PATCH 1/7] sched/pelt.c: Add option to make load and util calculations frequency invariant Thara Gopinath
2018-10-09 16:24 ` [RFC PATCH 2/7] sched/pelt.c: Add support to track thermal pressure Thara Gopinath
2018-10-09 16:24 ` [RFC PATCH 3/7] sched: Add infrastructure to store and update instantaneous " Thara Gopinath
2018-10-09 16:24 ` [RFC PATCH 4/7] sched: Initialize per cpu thermal pressure structure Thara Gopinath
2018-10-09 16:25 ` [RFC PATCH 5/7] sched/fair: Enable CFS periodic tick to update thermal pressure Thara Gopinath
2018-12-04 15:43 ` Vincent Guittot [this message]
2018-10-09 16:25 ` [RFC PATCH 6/7] sched/fair: update cpu_capcity to reflect " Thara Gopinath
2018-10-10 5:57 ` Javi Merino
2018-10-10 14:22 ` Thara Gopinath
2018-10-09 16:25 ` [RFC PATCH 7/7] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2018-10-10 5:44 ` [RFC PATCH 0/7] Introduce thermal pressure Javi Merino
2018-10-10 14:15 ` Thara Gopinath
2018-10-10 6:17 ` Ingo Molnar
2018-10-10 8:29 ` Quentin Perret
2018-10-10 8:50 ` Vincent Guittot
2018-10-10 9:55 ` Quentin Perret
2018-10-10 10:14 ` Vincent Guittot
2018-10-10 10:36 ` Quentin Perret
2018-10-10 12:04 ` Vincent Guittot
2018-10-10 12:23 ` Juri Lelli
2018-10-10 12:34 ` Vincent Guittot
2018-10-10 12:50 ` Juri Lelli
2018-10-10 13:08 ` Vincent Guittot
2018-10-10 13:34 ` Juri Lelli
2018-10-10 13:38 ` Vincent Guittot
2018-10-10 17:08 ` Thara Gopinath
2018-10-10 13:11 ` Quentin Perret
2018-10-10 13:05 ` Quentin Perret
2018-10-10 13:27 ` Vincent Guittot
2018-10-10 13:47 ` Quentin Perret
2018-10-10 15:19 ` Vincent Guittot
2018-10-10 16:15 ` Ionela Voinescu
2018-10-10 17:03 ` Thara Gopinath
2018-10-10 15:43 ` Thara Gopinath
2018-10-16 7:33 ` Ingo Molnar
2018-10-16 9:28 ` Lukasz Luba
2018-10-17 16:21 ` Thara Gopinath
2018-10-18 6:48 ` Ingo Molnar
2018-10-18 7:08 ` Rafael J. Wysocki
2018-10-18 7:50 ` Ingo Molnar
2018-10-18 8:14 ` Rafael J. Wysocki
2018-10-18 9:35 ` [PATCH 1/2] sched/cpufreq: Reorganize the cpufreq files Daniel Lezcano
2018-10-18 9:35 ` [PATCH 2/2] sched/cpufreq: Add the SPDX tags Daniel Lezcano
2018-10-18 9:42 ` [PATCH 1/2] sched/cpufreq: Reorganize the cpufreq files Rafael J. Wysocki
2018-10-18 9:54 ` Daniel Lezcano
2018-10-18 10:06 ` Rafael J. Wysocki
2018-10-18 10:13 ` Daniel Lezcano
2018-10-18 9:45 ` Daniel Lezcano
2018-10-19 5:24 ` kbuild test robot
2018-10-19 5:52 ` kbuild test robot
2018-10-18 9:44 ` [PATCH V2 " Daniel Lezcano
2018-10-18 9:44 ` [PATCH V2 2/2] sched/cpufreq: Add the SPDX tags Daniel Lezcano
2018-10-18 16:17 ` [RFC PATCH 0/7] Introduce thermal pressure Thara Gopinath
2018-10-19 8:02 ` Ingo Molnar
2018-10-19 11:29 ` Valentin Schneider
2018-10-10 15:35 ` Lukasz Luba
2018-10-10 16:54 ` Daniel Lezcano
2018-10-11 7:35 ` Lukasz Luba
2018-10-11 8:23 ` Daniel Lezcano
2018-10-12 9:37 ` Lukasz Luba
2018-10-10 17:30 ` Thara Gopinath
2018-10-11 11:10 ` Lukasz Luba
2018-10-16 17:11 ` Vincent Guittot
2018-10-17 16:24 ` Thara Gopinath
2018-10-18 8:00 ` Lukasz Luba
2018-10-18 8:12 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKfTPtB18Fh3neT7d6m0fgthE6Zo0am4i9WQ9OriD3FCuZgrRw@mail.gmail.com \
--to=vincent.guittot@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=quentin.perret@arm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).